[fix] 코딩 컨벤션 맞추기 #169
Merged
[fix] 코딩 컨벤션 맞추기 #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
1 task
youz2me
approved these changes
Jul 12, 2024
| mainTitleLabel.setText("직접 모임 추가하기", style: .body03, color: .gray8) | ||
| } | ||
| subTitleLabel.setText( | ||
| isReceived ? "초대 코드를 받았다면" : "초대 코드가 없다면", |
There was a problem hiding this comment.
생각보다 엄청 간단하게 삼항연산자를 구현할 수 있었네요 ,,, 감사합니다!
| @@ -51,53 +38,36 @@ class NicknameView: BaseView { | |||
|
|
|||
| override func setupView() { | |||
| backgroundColor = .white | |||
| addSubviews(navigationBar, separatorLine, subtitleLabel, nicknameTextField, errorLabel, nextButton) | |||
| navigationBar.addSubview(titleLabel) | |||
| addSubviews(subtitleLabel, nicknameTextField, errorLabel, nextButton) | |||
hooni0918
approved these changes
Jul 13, 2024
| @@ -39,7 +39,11 @@ class AppDelegate: UIResponder, UIApplicationDelegate { | |||
| } | |||
|
|
|||
| // 카카오 로그인 | |||
| func application(_ app: UIApplication, open url: URL, options: [UIApplication.OpenURLOptionsKey : Any] = [:]) -> Bool { | |||
| func application( | |||
| _ app: UIApplication, | |||
mmaybei
approved these changes
Jul 13, 2024
| } | ||
|
|
||
|
|
||
| // MARK: - Function |
There was a problem hiding this comment.
Function 마크 주석이 두 번 들어가서 이 주석은 삭제해도 좋을 것 같습니다!
|
아 그런데 네비게이션바 관련 코드를 수정하면서 네비게이션 아래 라인이 사라진 것 같아요! 수정이 필요할 것 같슴당 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 연결된 이슈
📄 작업 내용
절대 자기가 담당했던 코드 확인하세요!
동작도 작동하는지 확인해주세요!