-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MySQL protocol parser v1 #11800
base: master
Are you sure you want to change the base?
MySQL protocol parser v1 #11800
Conversation
@glongo I think you mentioned you had some WIP code as well. Care to have a look at this? |
NOTE: This PR may contain new authors. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #11800 +/- ##
=========================================
Coverage ? 82.22%
=========================================
Files ? 923
Lines ? 252159
Branches ? 0
=========================================
Hits ? 207349
Misses ? 44810
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the TBD list ;)
- update etc/schema.json
- update commit messages to contain Ticket number in the commit body (
Task #3446
) - update your git author to follow the format
FirstName LastName
:P
nit: in the commit messages, you can remove the rust/
portion
Yes sure. |
ea503dd
to
da79f32
Compare
5083bc9
to
3fe510b
Compare
I have fixed, please check again, thx. |
3fe510b
to
becd843
Compare
Make sure these boxes are signed before submitting your Pull Request -- thank you.
https://docs.suricata.io/en/latest/devguide/contributing/contribution-process.html
https://suricata.io/about/contribution-agreement/ (note: this is only required once)
Link to ticket: https://redmine.openinfosecfoundation.org/issues/3446
Describe changes:
This is a WIP patchset that implements an application layer for MySQL protocol, many features are not supported.
TBD:
Support Protocol:Handshake V9
Support Protocol:AuthSwitchRequest
Support Protocol:AuthSwitchResponse
Support Protocol:AuthMoreData
Support Protocol:AuthNextFactor
Support Compression
Add documentation
Add SV tests
Fix CI