Dns invalid additionals 7228 v4 #11794
Open
+73
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ticket: 7228 That means log the rest of queries and answers, even if the final field additionals is corrupt. Set an event in this case.
To accomodate cases found in QA. The case looks like a CnC channel on port 53, but not using DNS. First request has a very big record length, but all the header fields indicating numbers are 0. First reply has a very big record length as well, there is one non-zero field for number, but the flag indicates a request...
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #11794 +/- ##
==========================================
+ Coverage 82.53% 82.57% +0.03%
==========================================
Files 919 919
Lines 248979 249012 +33
==========================================
+ Hits 205506 205624 +118
+ Misses 43473 43388 -85
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
WARNING:
Pipeline 22741 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to ticket: https://redmine.openinfosecfoundation.org/issues/
https://redmine.openinfosecfoundation.org/issues/7228
Describe changes:
SV_BRANCH=OISF/suricata-verify#2032
#11785 with newer commit for the DNS probing parser improvement
@jasonish what do you think about it ?
Should we have a separate ticket and PR to handle first the probing parser ?