Merge pull request #42 from OCR-D/fixing-tests

fix tests: download when resolving
OCR-D · Oct 16, 2023 · bdbe6fc · bdbe6fc
2 parents 4b3cc79 + 6cef084
commit bdbe6fc
Show file tree

Hide file tree

Showing 7 changed files with 17 additions and 9 deletions.
diff --git a/.gitignore b/.gitignore
@@ -105,6 +105,5 @@ ENV/
 *.swp
 .pytest_cache
 tests/assets
-repo
 .pynative
 _*.png
diff --git a/.gitmodules b/.gitmodules
@@ -0,0 +1,3 @@
+[submodule "repo/assets"]
+	path = repo/assets
+	url = https://github.com/OCR-D/assets
diff --git a/Makefile b/Makefile
@@ -69,10 +69,14 @@ test: tests/assets
 # Assets
 #
 
-# Clone OCR-D/assets to ./repo/assets
-repo/assets:
-	mkdir -p $(dir $@)
-	git clone --quiet https://github.com/OCR-D/assets "$@"
+# Update OCR-D/assets submodule
+.PHONY: repos always-update tests/assets
+repo/assets: always-update
+	git submodule sync --recursive $@
+	if git submodule status --recursive $@ | grep -qv '^ '; then \
+		git submodule update --init --recursive $@ && \
+		touch $@; \
+	fi
 
 
 # Setup test assets

diff --git a/repo/assets b/repo/assets
diff --git a/tests/test_binarize.py b/tests/test_binarize.py
@@ -21,7 +21,8 @@ def workspace(tmpdir):
         shutil.rmtree(tmpdir)
     workspace = Resolver().workspace_from_url(
         assets.path_to('kant_aufklaerung_1784/data/mets.xml'),
-        dst_dir=tmpdir
+        dst_dir=tmpdir,
+        download=True
     )
     return workspace
 

diff --git a/tests/test_recognize.py b/tests/test_recognize.py
@@ -18,7 +18,7 @@ def test_recognize(self):
         resolver = Resolver()
         # with pushd_popd('/tmp/kraken-test') as tempdir:
         with pushd_popd(tempdir=True) as tempdir:
-            workspace = resolver.workspace_from_url(assets.path_to('communist_manifesto/data/mets.xml'), dst_dir=tempdir)
+            workspace = resolver.workspace_from_url(assets.path_to('communist_manifesto/data/mets.xml'), dst_dir=tempdir, download=True)
             workspace.overwrite_mode = True
             proc = KrakenRecognize(
                 workspace,

diff --git a/tests/test_segment.py b/tests/test_segment.py
@@ -17,7 +17,7 @@ def setUp(self):
     def test_run_blla(self):
         resolver = Resolver()
         with pushd_popd(tempdir=True) as tempdir:
-            workspace = resolver.workspace_from_url(assets.path_to('communist_manifesto/data/mets.xml'), dst_dir=tempdir)
+            workspace = resolver.workspace_from_url(assets.path_to('communist_manifesto/data/mets.xml'), dst_dir=tempdir, download=True)
             proc = KrakenSegment(
                 workspace,
                 input_file_grp="OCR-D-IMG-BIN",
@@ -31,7 +31,7 @@ def test_run_legacy(self):
         resolver = Resolver()
         # with pushd_popd('/tmp/kraken-test') as tempdir:
         with pushd_popd(tempdir=True) as tempdir:
-            workspace = resolver.workspace_from_url(assets.path_to('communist_manifesto/data/mets.xml'), dst_dir=tempdir)
+            workspace = resolver.workspace_from_url(assets.path_to('communist_manifesto/data/mets.xml'), dst_dir=tempdir, download=True)
             proc = KrakenSegment(
                 workspace,
                 input_file_grp="OCR-D-IMG-BIN",