-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[15.0][MIG] pricelist_cache #3122
Conversation
because is_pricelist_cache_available was stored, it caused concurrent access errors. I removed the stored=true attribute on the field, and improved performances in getting the status of parent lists by using sql recursive queries.
In order to avoid long running sql transactions, instead of creating 1 job per 3 pricelists, I'm now creating 1 for each huge pricelist (root or factor), and 3 for the others (which are smaller).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍
6fdf215
to
53661af
Compare
53661af
to
fde9448
Compare
/ocabot migration pricelist_cache |
The migration issue (#1741) has not been updated to reference the current pull request because a previous pull request (#2601) is not closed. |
Ok, that's why it's advised to create tests data directly in the module and not rely on Odoo's ones. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review
Hi @rousseldenis |
This PR has the |
/ocabot merge nobump |
On my way to merge this fine PR! |
Congratulations, your PR was merged at 603baf9. Thanks a lot for contributing to OCA. ❤️ |
I've modified the tests to fix them because the price of a product from Odoo product module has changed:
It's caused by the odoo/addons/product module data change of a product:
The one used here:
https://github.com/juanpgarza/sale-workflow/blob/15.0-mig-pricelist_cache/pricelist_cache/data/demo.xml#L121
With the ID 18;
image
V14.0:
https://github.com/odoo/odoo/blob/14.0/addons/product/data/product_demo.xml#L285
Price: 79.0
V15.0:
https://github.com/odoo/odoo/blob/15.0/addons/product/data/product_demo.xml#L285
Price: 15.8
After updating the price, the tests passes.