Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[15.0][MIG] sale_order_lot_selection #1752

Closed
wants to merge 57 commits into from
Closed

[15.0][MIG] sale_order_lot_selection #1752

wants to merge 57 commits into from

Conversation

bizzappdev
Copy link
Contributor

@bizzappdev bizzappdev commented Oct 26, 2021 •
edited
Loading

hurrinico and others added 30 commits October 25, 2021 19:52
@bizzappdev
[FIX] Add sale order dolder
9bcfc0e
@bizzappdev
[FIX] adds _run_move_create and some other fixes
92b62a4
@bizzappdev
[FIX] add restriction on sale confirm changed icon and minor fix
e2afeba 
[FIX] Fix product_id on test

[FIX] Fix product on test
@bizzappdev
[FIX] Add check on sale order
5ac8962
@bizzappdev
[FIX] add _run override
c2ca317
@bizzappdev
[FIX] adding feature and fix contributors
f8909ff
@bizzappdev
Add transmition of lot_id from move to procurement and delete lot_id on
d00daec 
copy
@bizzappdev
Extract move state check for easier inherit and add copy=False instead
b73015b 
of copy method
@bizzappdev
Fix pep8 and edit check move state
cfdb11f
@bizzappdev
Fix unused import
cf07962
@eLBati @bizzappdev
[IMP] better lot names in tests
8cfc55e
@bizzappdev
[FIX] Fixed Tests adding a stock_picking_in to create quants
8713f18 
[FIX] Use product_14 instead of product_11

[FIX] Add test's flow step
@bizzappdev
[FIX] Add check on lot reservation in test
96dc2ad
@bizzappdev
[FIX] Add check on quants
449176f 
[FIX] change data in quant search

[FIX] Fixed tab

[FIX] Add check on lots list

FIX product_id_change_with_wh
@eLBati @bizzappdev
Refactoring product_id_change_with_wh for domain generation.
f41ef6f 
Because quants_get_prefered_domain does not return quants with our lots, if other quants are available
@eLBati @bizzappdev
Refactoring tests, adding onchange tests
8c72882
@eLBati @bizzappdev
Remove never used domain: on_change will set the correct domain for l…
79057e3 
…ot_id field
@eLBati @bizzappdev
IMP module version and fix comment
fc8f2c0
@eLBati @bizzappdev
the field lot_id should only be visible to the members of the stock.g…
e12811e 
…roup_production_lot res.groups
@eLBati @bizzappdev
REF some code and ADD lot11 has 1 availability and order4 has quantity 2
29db827
@eLBati @bizzappdev
REF product_id_change_with_wh for compatibility with ohter override
706d440
@eLBati @bizzappdev
FIX default value in context
4085e4a
@eLBati @bizzappdev
IMP README
7bda022
@eLBati @bizzappdev
FIX You cannot transfer a picking in state 'False'
c75658c
@sebastienbeau @bizzappdev
[FIX] fix perf issue with sale_order_lot_selection
dadfb35
@eLBati @bizzappdev
FIX OCA#269
186306c 
Steps to reproduce:

1.- Create a new Sale Order with 2 or more lines of products
2.- Assign lot to every line (ensure lot has stock available)
3.- Confirm the Sale Order
4.- Go to the Delivery Order

Result:

Only the first line in the Delivery Order is in state "Available" and reserved, the rest of the lines are in state "Waiting Availability" and not reserved
@florian-dacosta @bizzappdev
Migrate sale_order_lot_selection to v9
fe752a0
@florian-dacosta @bizzappdev
[FIX] return super result after sale order confirm
76539ed
@pedrobaeza @bizzappdev
[MIG] Make modules uninstallable
140e9c7
@pedrobaeza @bizzappdev
[MIG] Rename manifest files
a224b29
@bizzappdev bizzappdev mentioned this pull request Oct 26, 2021
Open
@bizzappdev
Copy link
Contributor Author

@pedrobaeza the new workflow for test isnt supporting oca_dependencies.txt
I have added proper things. still it is not able to find the dependent module.

ERROR: Could not find a version that satisfies the requirement odoo-addon-stock_restrict_lot<15.1dev,>=15.0dev (from versions: none)

@pedrobaeza
Copy link
Member

You have to ask @sbidoul about the pip CI flow.

@sbidoul
Copy link
Member

sbidoul commented Oct 28, 2021

For referencing unmerged PRs, create a file named test-requirements.txt pointing to the python project of the unmerged addon, i.e. odoo-addon-stock_restrict_lot @ git+https://github.com/oca/{repo}@refs/pull/{pr}/head#subdirectory=setup/stock_restrict_lot.

You'll get used to it too, Pedro ;)

@bizzappdev
Copy link
Contributor Author

For referencing unmerged PRs, create a file named test-requirements.txt pointing to the python project of the unmerged addon, i.e. odoo-addon-stock_restrict_lot @ git+https://github.com/oca/{repo}@refs/pull/{pr}/head#subdirectory=setup/stock_restrict_lot.

You'll get used to it too, Pedro ;)

Thank you so much. it worked. :)

@bizzappdev
Copy link
Contributor Author

OCA/stock-logistics-workflow#921 has been merged so this can also proceed for review and merge
@dreispt

@nicomacr
Copy link
Contributor

@bizzappdev could you made a rebase for this PR?

@mcassuto
Copy link

@dreispt Dependency has been merged

@rousseldenis
Copy link
Contributor

/ocabot migration sale_order_lot_selection

@OCA-git-bot OCA-git-bot added this to the 15.0 milestone Jun 22, 2023
@OCA-git-bot
Copy link
Contributor

The migration issue (#1741) has not been updated to reference the current pull request because a previous pull request (#2207) is not closed.
Perhaps you should check that there is no duplicate work.
CC @nicomacr

@rousseldenis
Copy link
Contributor

rousseldenis commented Jun 22, 2023 •
edited
Loading

@bizzappdev Do you mind if we switch to #2207 ?

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 5, 2023

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Nov 5, 2023
@mcassuto
Copy link

mcassuto commented Nov 5, 2023

There is already a PR for this module:
#2207

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Nov 12, 2023
@rousseldenis
Copy link
Contributor

@bizzappdev Do you mind if we switch to #2207 ?

@bizzappdev
Copy link
Contributor Author

@bizzappdev Do you mind if we switch to #2207 ?

feel free to proceed further :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
needs review
Projects
None yet
Milestone
15.0
Development

Successfully merging this pull request may close these issues.