Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13.0][MIG] datev_export_xml : Migration to version 13.0 #137

Merged
merged 4 commits into from
May 13, 2024

Conversation

carolinafernandez-tecnativa
Copy link

@carolinafernandez-tecnativa carolinafernandez-tecnativa commented Nov 28, 2023

-Standard migration to v13.

  • Change tests: _check_filecontent, _run_test_document and _run_test_invoice in order to avoid getting this error:

ValueError: empty namespace prefix is not supported in ElementPath

TT46193

@pedrobaeza

@carolinafernandez-tecnativa carolinafernandez-tecnativa force-pushed the 13.0-mig-datev_export_xml branch 2 times, most recently from f5d9138 to 979f4a3 Compare November 29, 2023 13:21
Copy link

github-actions bot commented May 5, 2024

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label May 5, 2024
@carolinafernandez-tecnativa
Copy link
Author

datev_export_xml/tests/test_datev_export.py Outdated Show resolved Hide resolved
@@ -81,6 +79,7 @@ def setUp(self):
self.refund_date = self.today - timedelta(days=55)
self.start_date = self.today - timedelta(days=34)
self.end_date = self.today - timedelta(days=32)
self.InvoiceObj.search([("state", "=", "posted")]).button_draft()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is it necessary?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is necessary, as there is a restriction in account move that you cannot delete an item linked to a posted entry.

datev_export_xml/models/account_move.py Outdated Show resolved Hide resolved
datev_export_xml/demo/export_data.xml Outdated Show resolved Hide resolved
@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label May 12, 2024
@carolinafernandez-tecnativa carolinafernandez-tecnativa force-pushed the 13.0-mig-datev_export_xml branch 2 times, most recently from 13f67b1 to 5c50214 Compare May 13, 2024 10:13
Copy link

@pilarvargas-tecnativa pilarvargas-tecnativa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@pedrobaeza pedrobaeza added this to the 13.0 milestone May 13, 2024
@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 13.0-ocabot-merge-pr-137-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 8e8a2f5 into OCA:13.0 May 13, 2024
5 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 341f9a5. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza deleted the 13.0-mig-datev_export_xml branch May 13, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants