[16.0][FIX] equal Estadual Inscription detection #3450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @renatonlima, @rvalyi, |
antoniospneto
changed the title
antoniospneto
approved these changes
Oct 17, 2024
mileo
approved these changes
Oct 18, 2024
|
/ocabot merge minor |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Congratulations, your PR was merged at 1917c90. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quando a opção "Multiple partners with the same CNPJ" está marcada, está sendo possível criar dois parceiros com o mesmo CNPJ e também com a mesma inscrição estadual.
Porém quando o primeiro registro está com esse campo vazio, o segundo não pode ser criado e a mensagem diz que a IE já está sendo usada.
Esse PR apenas altera a condição para que a restrição ocorra quando os campo não são vazios. Pra mim parece prudente permitir que os dois registros estejam com esse campo vazio, pois permite usar essa funcionalidade para casos em que a IE não é relevante para o usuário.