Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][MIG] partner_default_delivery_carrier: Migration to 16.0 #727

Closed
wants to merge 3 commits into from
Closed

[16.0][MIG] partner_default_delivery_carrier: Migration to 16.0 #727

wants to merge 3 commits into from

Conversation

BT-mrobles
Copy link

@BT-mrobles BT-mrobles commented Oct 30, 2023 •
edited
Loading

issue #534

Migration from 14.0

@BT-mrobles BT-mrobles force-pushed the 16.0-mig-partner_default_delivery_carrier branch 2 times, most recently from 34efff5 to be8e890 Compare October 30, 2023 16:30
@BT-mrobles
Copy link
Author

@hildickethan-S73 @OscarIndias

@BT-mrobles BT-mrobles force-pushed the 16.0-mig-partner_default_delivery_carrier branch 4 times, most recently from a46b06b to 0cba606 Compare October 31, 2023 08:58
@BT-mrobles BT-mrobles force-pushed the 16.0-mig-partner_default_delivery_carrier branch from b4e1924 to ee3c49d Compare October 31, 2023 09:03
@BT-mrobles BT-mrobles mentioned this pull request Oct 31, 2023
Open
32 tasks
hildickethan
hildickethan approved these changes Nov 6, 2023
View reviewed changes
Copy link
Member

@hildickethan hildickethan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code + functional review

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@rousseldenis
Copy link
Contributor

/ocabot migration partner_default_delivery_carrier

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Nov 10, 2023
rousseldenis
rousseldenis reviewed Nov 10, 2023
View reviewed changes
partner_default_delivery_carrier/models/res_config_settings.py

partner_default_delivery_carrier_id = fields.Many2one("delivery.carrier")

def get_values(self):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not the good implementation in this version.

You should declare the field also on res.company. And here, change the field as related as : related=company_id.partner_default_delivery_carrier_id.

@github-actions GitHub Actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Mar 10, 2024
@github-actions github-actions bot closed this Apr 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rousseldenis rousseldenis rousseldenis left review comments

@BT-anieto BT-anieto BT-anieto approved these changes

@hildickethan hildickethan hildickethan approved these changes

Assignees
No one assigned
Labels
approved ready to merge stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
6 participants
@BT-mrobles @OCA-git-bot @rousseldenis @hildickethan @BT-anieto @SilvioC2C