Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Components Section for reusability #57

Merged
merged 29 commits into from
Aug 2, 2023
Merged

Components Section for reusability #57

merged 29 commits into from
Aug 2, 2023

Conversation

frankkilcommins
Copy link
Collaborator

  • Reusable Workflow Inputs
  • Reusable Parameters

fixes #43

shaisachs and others added 19 commits April 26, 2023 10:00
@shaisachs
Add components facility (#43)
a408a36 
Signed-off-by: Shai Sachs <[email protected]>
@shaisachs
add credit
6a42a02 
Signed-off-by: Shai Sachs <[email protected]>
@shaisachs
pagination is a better example of an operation param; store is a bett…
254b277 
…er example of a workflow input

Signed-off-by: Shai Sachs <[email protected]>
@shaisachs
add and consume reference object
b7844a0 
Signed-off-by: Shai Sachs <[email protected]>
@shaisachs
add example of reusing steps and parameters
9fbf292 
Signed-off-by: Shai Sachs <[email protected]>
@shaisachs
fix components row
dd367b9 
Signed-off-by: Shai Sachs <[email protected]>
@shaisachs
add overridable value property (#43)
d556b2b 
Signed-off-by: Shai Sachs <[email protected]>
@shaisachs
allow input refs (#43)
5946142 
Signed-off-by: Shai Sachs <[email protected]>
@shaisachs
remove mention of references in workflowinputs (#43)
c627f16 
Signed-off-by: Shai Sachs <[email protected]>
@shaisachs
unwind components in steps; use reusable workflows
9d45822 
Signed-off-by: Shai Sachs <[email protected]>
@shaisachs
update example to use JSON Schema more correctly
9f553c8 
Signed-off-by: Shai Sachs <[email protected]>
@shaisachs
fix formatting, more standard component description
27b3bfa 
Signed-off-by: Shai Sachs <[email protected]>
@frankkilcommins
Merge pull request #56 from OAI/main
ca3f6fb 
Merging main before reviewing other PRs
@frankkilcommins
Update versions/1.0.0.md
d965fbb 
reverting steps back to original description
@frankkilcommins
Update versions/1.0.0.md
f810363 
I do not see why we would not allow extensibility here if so desired by authors.
@frankkilcommins
typo in reference object section
d0d9015
@frankkilcommins
Merge branch 'draft-version-minor-enrichment' into draft-version-mino…
d59e165 
…r-enrichment
@frankkilcommins
Merge pull request #51 from shaisachs/draft-version-minor-enrichment
76ff21e 
Components proposal
@frankkilcommins
tidy up components and reference object additions
4bfb132
shaisachs and others added 10 commits July 18, 2023 22:32
@shaisachs
replace source name with sourceId
8c26d39 
Signed-off-by: Shai Sachs <[email protected]>
@shaisachs
add workflowIdSourceId to disambiguate workflowId collisions
65e0c21 
Signed-off-by: Shai Sachs <[email protected]>
@shaisachs
Correct id/sourceId
5b8e4e5
@shaisachs
fix source object example
532e99c 
Signed-off-by: Shai Sachs <[email protected]>
@shaisachs
better disambiguation language as used in operationid.
4f1d7ff 
Signed-off-by: Shai Sachs <[email protected]>
@shaisachs
revert to name and add regex
06211ec 
Signed-off-by: Shai Sachs <[email protected]>
@shaisachs
rename sources to sourceDocuments
ab33786 
Signed-off-by: Shai Sachs <[email protected]>
@shaisachs
fix markdown
05dc5d0 
Signed-off-by: Shai Sachs <[email protected]>
@shaisachs
fix link
6852e00 
Signed-off-by: Shai Sachs <[email protected]>
@frankkilcommins
Merge pull request #59 from shaisachs/feature/disambiguate-workflow
73074a9 
Disambiguate workflows
@frankkilcommins frankkilcommins merged commit 88068d8 into main Aug 2, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikeRalphson MikeRalphson Awaiting requested review from MikeRalphson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add components section to improve reusability through referencing within the spec
2 participants
@frankkilcommins @shaisachs