Corrected Memory Free Issue

- Addressed issue where memory was being freed improperly that was causing an issue during auth prompting.
NoMoreFood · Jan 17, 2022 · cc9714d · cc9714d
1 parent 805e690
commit cc9714d
Show file tree

Hide file tree

Showing 24 changed files with 60 additions and 60 deletions.
diff --git a/binaries/puttycac-0.76u3.zip b/binaries/puttycac-0.76u3.zip
diff --git a/binaries/puttycac-0.76u3-installer.msi → binaries/puttycac-0.76u4-installer.msi b/binaries/puttycac-0.76u3-installer.msi → binaries/puttycac-0.76u4-installer.msi
diff --git a/binaries/puttycac-0.76u4.zip b/binaries/puttycac-0.76u4.zip
diff --git a/binaries/puttycac-64bit-0.76u3.zip b/binaries/puttycac-64bit-0.76u3.zip
diff --git a/binaries/puttycac-64bit-0.76u3-installer.msi → binaries/puttycac-64bit-0.76u4-installer.msi b/binaries/puttycac-64bit-0.76u3-installer.msi → binaries/puttycac-64bit-0.76u4-installer.msi
diff --git a/binaries/puttycac-64bit-0.76u4.zip b/binaries/puttycac-64bit-0.76u4.zip
diff --git a/binaries/puttycac-hash.txt b/binaries/puttycac-hash.txt
@@ -1,69 +1,69 @@
 
 Algorithm       Hash                                                                   Path
 ---------       ----                                                                   ----
-SHA256          99AFBE1AB0FCBB1A2C5DD9B44787502EBEA0BBF8026552A224A7358E31C15CCC       x64\pageant.exe
-SHA256          268C402267EA07EA25948E547A2B0CA911B84C512F830EC62BE51512BB684B47       x64\plink.exe
-SHA256          4CF4FE07D0C475CEAD7E8341A1BE5AB6F57D2BCABC19E4CF3409B48F15850E87       x64\pscp.exe
-SHA256          650D66A57550795B3F45F62F4DA8AF206C37086463A51EB270EEF4FD12B8B663       x64\psftp.exe
-SHA256          8880037F8EB5A5413EE517FC20E311DB2B03CCA04368555503DADF6F2530F14F       x64\putty.exe
-SHA256          24E497A61A0C3E5A2CDDE511AE95E4AB5975B584F5CF7568B253EC4D5B2ECBAA       x64\puttygen.exe
-SHA256          A3DDD8CBFB6C42D40E11315040E963FBEEC315941136BADB1D412E2E0902666C       x64\puttytel.exe
-SHA256          9FF702CE50AADBA6C28CDBD6F14103FA92965EEB00DCCF5D0AB3F6B68A53342D       x86\pageant.exe
-SHA256          20F9C52796F8416E4A3EFFB3D1566E5DAA9CCC680587077439C518DAFF4B6421       x86\plink.exe
-SHA256          39538899F7169BA46A83F0BB9AD86FC0A1C081AC92787DACF6B505428460E363       x86\pscp.exe
-SHA256          79288DB757FFA4E0304DED5510E1177A5C1FAC8319076514EC9A50AF2681E0FF       x86\psftp.exe
-SHA256          E9C223EAD768637AC5B4E5615D75C2C1929D63FEC148E5D074A2F71F6A30A204       x86\putty.exe
-SHA256          F4CF24B339BB8A037B91EC6FE996770E36AB475CB9C13BE6D4D41FF2132386B9       x86\puttygen.exe
-SHA256          63E34D1A26AC35426896F6298A620290C1C856BC0D5532B784FB9F47A634168B       x86\puttytel.exe
-SHA256          57D14CCB4C0C25AE418544E37682A79D26729BB1798518F71AD494B9CBD0C561       puttycac-0.76u3-installer.msi
-SHA256          93E0E94731561578AF08C4A8737709EE5546E68C05AEE666BA221431B11CFF34       puttycac-0.76u3.zip
-SHA256          7BCB75CC32377D05365039200D6065AB4ED3D7B75E00FA005CB63F84B76133AF       puttycac-64bit-0.76u3-installer.msi
-SHA256          C8755DDDA98343786C0B2DFBE2E20087161244BAE09EBA34ED1D8D06DEEAF041       puttycac-64bit-0.76u3.zip
+SHA256          810AC2574AD5A799293A91A530C7BD854C7A059B8146765F717B542D2822BB04       x64\pageant.exe
+SHA256          102606D6E5139F86892E2FFBEEFD37790A7DED31C59AFD15E8AC7336F603A353       x64\plink.exe
+SHA256          253087455652110E16FC5950980545E215CA23122C72E573F4BC9ED8A517EA94       x64\pscp.exe
+SHA256          1C43258344EE5F8373240E74D5D073D5DFD50BC62A4700B241D47FD40FB2BB78       x64\psftp.exe
+SHA256          53078EEABC833AD02E64F6A316B450EB319E24E2F00A85BF85EE171F7E29FAE1       x64\putty.exe
+SHA256          F21D9E33F5840D2A827FE80847E353B0B60AD14584AD0C062B8C030816280E2E       x64\puttygen.exe
+SHA256          BD5D719A347777C2515178C0FF45DB6C1EEC4EC9BD452FA1DE751D0F3A981478       x64\puttytel.exe
+SHA256          D0196B444AB1E1A5C17FC9D11DA0D9C7D82D9505E690AE1941FACC91540D937C       x86\pageant.exe
+SHA256          ED6D7EFF07B67B2A9E6DEDE5C6B23AAF7C1628C5FBB51848CE257739F3EAD10A       x86\plink.exe
+SHA256          4676E86E509E83CA681B3EC5A70C72FB260DEA10FD3C2B50254E438444EEC7CC       x86\pscp.exe
+SHA256          7386AC28183471668D251DF171E8548E37A5121F04E244576C7DBF22A87DF571       x86\psftp.exe
+SHA256          E6A053E0F2AE8734F1A3397B0C258DCE738B3EE801680B14DFA227945AC0CEC0       x86\putty.exe
+SHA256          2535331BD97095B92AE487DCB2D6ABC268A21086FBD9795A9E0AD937EC91D6ED       x86\puttygen.exe
+SHA256          5FAC309CF96E11AA90D79BC0FFED50A14ACBAB80941DFD0F0AC21C7801A03E3F       x86\puttytel.exe
+SHA256          DC59470E07A7E54E0E24663BD9461FE685E90DC2CA816E17562F70E0892A675B       puttycac-0.76u4-installer.msi
+SHA256          C43961EE08F380DBED13A11E315DAC1A9B0F6119A5E581332473E49CCBE2114B       puttycac-0.76u4.zip
+SHA256          401BE068B9EEFDF20B298DEE3B2EF1A48E9B881049514CE7169E4EFC49D7918E       puttycac-64bit-0.76u4-installer.msi
+SHA256          CD4DB5A25AF46D8084905A25392497AB0066E3972C9AEE571BB7EBDD645BDD84       puttycac-64bit-0.76u4.zip
 
 
 
 Algorithm       Hash                                                                   Path
 ---------       ----                                                                   ----
-SHA1            C38D8C4BD62C70AC1BB35B491D62F9E0A8B36E99                               x64\pageant.exe
-SHA1            D5A61C74702002992DE98C57CCF955A2442D5BBF                               x64\plink.exe
-SHA1            F2D19945A6E3DAAE8A84A79498A3ECC5364B0D44                               x64\pscp.exe
-SHA1            EE0A6FC727FCBA217F1E08DFD2211D3CB7E844B1                               x64\psftp.exe
-SHA1            8EF3F294A5B8F24A3DCBDB500788562AC5328E79                               x64\putty.exe
-SHA1            3BBE560D68FC2B658159CD49FC8B39220D1B60AC                               x64\puttygen.exe
-SHA1            87E65B3309B82DC35FEDC48F388B68518F73EFF6                               x64\puttytel.exe
-SHA1            818B3E9517FE57BEA7E62636171FAE7D45643276                               x86\pageant.exe
-SHA1            BC0218CD113464669352CB6FD4E77FB193D5CC09                               x86\plink.exe
-SHA1            6C4CBB4E978DDE58C4CA72BAA063E9C64AF742EB                               x86\pscp.exe
-SHA1            E8DCE546F5F2D98A2F1327C9F23A7B46A303F8C4                               x86\psftp.exe
-SHA1            F106E94EA4E289C7EAD83A7B0AB699334951D3A4                               x86\putty.exe
-SHA1            E8CC2558D03CD216067EC23D8517F7FDA519D464                               x86\puttygen.exe
-SHA1            E114600C103FD7CF8A6DDB5888E55617966CAF5D                               x86\puttytel.exe
-SHA1            015E0FF1E95FE7EEF727B2E90A124AD1796EF073                               puttycac-0.76u3-installer.msi
-SHA1            38FDCFCFC56D8D2943418FDE1304DD2EB5D19FAB                               puttycac-0.76u3.zip
-SHA1            C5F82B5CB6A8139FC2BC80A0B62BAB8FEAD08FB3                               puttycac-64bit-0.76u3-installer.msi
-SHA1            5C933E4BD9178A793565155F9DCCB4ED2BFE1379                               puttycac-64bit-0.76u3.zip
+SHA1            94D6FF56617393F0AEF9B1B4AD98E95CDF4E3EC3                               x64\pageant.exe
+SHA1            BE77683BFE95E26E1F8D46FF3055B62D65B54895                               x64\plink.exe
+SHA1            142872FE9EDFC91DE8CF39EA11B36CFED34789A1                               x64\pscp.exe
+SHA1            A63FCC08898E7CFD3F06565C913D6FF404E7D48E                               x64\psftp.exe
+SHA1            16484DE617D7EB5772CC852910CB44600B2A63EB                               x64\putty.exe
+SHA1            815E7FE11D254796635796ACF56BE1C11AD1FB1B                               x64\puttygen.exe
+SHA1            982C366A097E64422E666FE11ACC9BA525F537E2                               x64\puttytel.exe
+SHA1            869434760A3CD5A9FFA62AB7D9D37B2F410BDEF3                               x86\pageant.exe
+SHA1            069EBBED203AC492AAB81652168A9DFFD789C48A                               x86\plink.exe
+SHA1            0CD40B17BE62F6F33C42AEC409B1493E464CB1CC                               x86\pscp.exe
+SHA1            38E66A6530B37C223E694B671D7C4B3C253CE94F                               x86\psftp.exe
+SHA1            D04446283E31CB5C9FACCA3DBF2C9D2A85160720                               x86\putty.exe
+SHA1            4855453518D4CC1398553B71F95937BD22F6AC17                               x86\puttygen.exe
+SHA1            C97FFA3992D041B82232D3E82654C8969C2DAE15                               x86\puttytel.exe
+SHA1            FC973F0B2E1F72CB58E4857E2A0BD66625E8FEE8                               puttycac-0.76u4-installer.msi
+SHA1            C0D6B345458782075EEB55652CDA9688A000D16E                               puttycac-0.76u4.zip
+SHA1            3DFCE37F5F6AD6474EAF08D3A22F6337192246B7                               puttycac-64bit-0.76u4-installer.msi
+SHA1            C08D5E69C331D84E66DE5C8435CB0F7B625A0093                               puttycac-64bit-0.76u4.zip
 
 
 
 Algorithm       Hash                                                                   Path
 ---------       ----                                                                   ----
-MD5             64C9398ADD9DA38B5AA936CBD4092E65                                       x64\pageant.exe
-MD5             8F67B3555B512E93A4B4A2A1BC367DA4                                       x64\plink.exe
-MD5             9275F93040174BB13E2E78DE2B6DED45                                       x64\pscp.exe
-MD5             DE0D42E32B16DAB71BE68AADDBAECA31                                       x64\psftp.exe
-MD5             80242CCA8A62F54DE82615224F3267F1                                       x64\putty.exe
-MD5             9FC91344DB58C247A19AC690712594F4                                       x64\puttygen.exe
-MD5             5191758AA2AC94CBA167B6D41D8E29F8                                       x64\puttytel.exe
-MD5             B66736514BA93F841AAC15CE9ED16906                                       x86\pageant.exe
-MD5             83B13795918141DE22A635AD1CD54D3A                                       x86\plink.exe
-MD5             2890BB5FA50F2847CE2D2FFC57B8148A                                       x86\pscp.exe
-MD5             2A86F4AA5AFEF2B0A996A9664C0DAB85                                       x86\psftp.exe
-MD5             A2D862B2E215E34847DFE762FA516D93                                       x86\putty.exe
-MD5             6A913FF108FACBEDA20B89108019579A                                       x86\puttygen.exe
-MD5             5DFE1DB029966AA7D6836ECF1504FA93                                       x86\puttytel.exe
-MD5             CF701681F4EBD6E9C37433A6CEB9E970                                       puttycac-0.76u3-installer.msi
-MD5             52163E540902E19D8908446F60E1AEF1                                       puttycac-0.76u3.zip
-MD5             C0847297FD41AE663A24FB388C7AE348                                       puttycac-64bit-0.76u3-installer.msi
-MD5             9BA40200A80AD7B7411D8E9F154FDE9A                                       puttycac-64bit-0.76u3.zip
+MD5             A071EBE267B9E37BF8BA9311467058A4                                       x64\pageant.exe
+MD5             D8E9B5687D6BEBC92A2AE9F086D9BF45                                       x64\plink.exe
+MD5             237E0A70A882187E1BCA19FE616A850D                                       x64\pscp.exe
+MD5             6B700FA6EC97B19CEE276476CFB62A0E                                       x64\psftp.exe
+MD5             3772794AE4948298549437E56F0EF6B3                                       x64\putty.exe
+MD5             53F2AD53D3C7BA8851247BC49300BB82                                       x64\puttygen.exe
+MD5             D04FF295D65262548AA0E68892E62AF0                                       x64\puttytel.exe
+MD5             2FB16B2CE289CAF59A116BECCDECE1DF                                       x86\pageant.exe
+MD5             69DA19485709EC5DD7F075E34FDDF437                                       x86\plink.exe
+MD5             FBAC6B64DF12D5F9164071BC656F9C90                                       x86\pscp.exe
+MD5             E1A4B9D1E386CF68B5D203D8223A747F                                       x86\psftp.exe
+MD5             45D15165C805F7C49497F501AFB3EBD1                                       x86\putty.exe
+MD5             54209F5CA2B961D27976B5952B675F3B                                       x86\puttygen.exe
+MD5             1EBE2013FEFA9D15ACA3BF8629B2E64B                                       x86\puttytel.exe
+MD5             1130B3C2ABCC1562A9F3D9C521410F09                                       puttycac-0.76u4-installer.msi
+MD5             B90F2745D14A6728AB3DC0D00FB349A6                                       puttycac-0.76u4.zip
+MD5             FA278133D2F99262023BBB5733CA2843                                       puttycac-64bit-0.76u4-installer.msi
+MD5             7E9B263E50A101BED77034EEB930243B                                       puttycac-64bit-0.76u4.zip
 
 
diff --git a/binaries/x64/pageant.exe b/binaries/x64/pageant.exe
diff --git a/binaries/x64/plink.exe b/binaries/x64/plink.exe
diff --git a/binaries/x64/pscp.exe b/binaries/x64/pscp.exe
diff --git a/binaries/x64/psftp.exe b/binaries/x64/psftp.exe
diff --git a/binaries/x64/putty.exe b/binaries/x64/putty.exe
diff --git a/binaries/x64/puttygen.exe b/binaries/x64/puttygen.exe
diff --git a/binaries/x64/puttytel.exe b/binaries/x64/puttytel.exe
diff --git a/binaries/x86/pageant.exe b/binaries/x86/pageant.exe
diff --git a/binaries/x86/plink.exe b/binaries/x86/plink.exe
diff --git a/binaries/x86/pscp.exe b/binaries/x86/pscp.exe
diff --git a/binaries/x86/psftp.exe b/binaries/x86/psftp.exe
diff --git a/binaries/x86/putty.exe b/binaries/x86/putty.exe
diff --git a/binaries/x86/puttygen.exe b/binaries/x86/puttygen.exe
diff --git a/binaries/x86/puttytel.exe b/binaries/x86/puttytel.exe
diff --git a/code/cert/cert_common.c b/code/cert/cert_common.c
@@ -162,7 +162,7 @@ BOOL cert_confirm_signing(LPCSTR sFingerPrint, LPCSTR sComment)
 
 	// prompt user
 	BOOL bIsCert = cert_is_certpath(sComment);
-	LPSTR sDescription = bIsCert ? cert_subject_string(sComment) : sComment;
+	LPSTR sDescription = bIsCert ? cert_subject_string(sComment) : dupstr(sComment);
 	LPSTR sMessage = dupprintf("%s\r\n\r\n%s: %s\r\n%s: %s\r\n\r\n % s",
 		"An application is attempting to authenticate using a certificate or key with the following details:",
 		bIsCert ? "Subject" : "Comment", sDescription,

diff --git a/code/version.h b/code/version.h
@@ -1,6 +1,6 @@
 /* Generated by automated build script */
 #define RELEASE 0.76
-#define TEXTVER "Release 0.76-3"
-#define SSHVER "-Release-0.76-3"
-#define BINARY_VERSION 0,76,0,3
+#define TEXTVER "Release 0.76-4"
+#define SSHVER "-Release-0.76-4"
+#define BINARY_VERSION 0,76,0,4
 #define SOURCE_COMMIT "See https://github.com/NoMoreFood/putty-cac"
diff --git a/packager/build.cmd b/packager/build.cmd
@@ -2,8 +2,8 @@
 TITLE Building PuTTY-CAC
 
 :: version information
-SET VER=0.76u3
-SET VERN=0.76.0.3
+SET VER=0.76u4
+SET VERN=0.76.0.4
 
 :: cert info to use for signing
 SET CERT=BC4F81C0B3B32755A8CC9A6B91713958294788F0