Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed documentation for missing argument #913

Merged
merged 3 commits into from
Mar 4, 2024
Merged

removed documentation for missing argument #913

merged 3 commits into from
Mar 4, 2024

Conversation

yarnabrina
Copy link
Contributor

Closes #910

Documentation for LSTM mentioned encoder_activation argument, but it was not present in __init__. This PR removes this from the docstring.

@CLAassistant
Copy link

CLAassistant commented Mar 4, 2024

CLA assistant check
All committers have signed the CLA.

@jmoralez
Copy link
Member

jmoralez commented Mar 4, 2024

Thanks @yarnabrina. Can you please also remove it from the notebook? You can refer to the contributing file for more details. Also please let us know if you feel something's missing from it.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Member

@jmoralez jmoralez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jmoralez jmoralez enabled auto-merge (squash) March 4, 2024 19:24
@jmoralez jmoralez merged commit 10bb2e2 into Nixtla:main Mar 4, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] LSTM model does not have encoder_activation parameter but contains in the docstring
3 participants