Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] LSTM model does not have encoder_activation parameter but contains in the docstring #910

Closed
yarnabrina opened this issue Mar 2, 2024 · 3 comments · Fixed by #913
Closed

Comments

@yarnabrina
Copy link
Contributor

I've noticed that LSTM model does not have encoder_activation as an argument in __init__ but it's documented in the docstring.

`encoder_activation`: str=`tanh`, type of LSTM activation from `tanh` or `relu`.<br>

@jmoralez
Copy link
Member

jmoralez commented Mar 2, 2024

I think this is the same as #426

@yarnabrina
Copy link
Contributor Author

Yes. If you want, this can be closed as duplicate.

Will you accept a PR removing the line from docstring? The alternative by adding a new argument (similar to how it's there for RNN) will likely be a breaking change for users relying on order of keyword arguments.

@jmoralez
Copy link
Member

jmoralez commented Mar 4, 2024

Will you accept a PR removing the line from docstring?

Yes, it doesn't seem to be used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants