Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

twitch-dl: add ffmpeg to application path #345303

Merged
merged 1 commit into from
Sep 29, 2024
Merged

Conversation

hauskens
Copy link
Contributor

Description of changes

  • Added ffmpeg to PATH
  • Added Hausken as maintainer

ffmpeg was missing in path, so if you dont have ffmpeg installed you would get an error when using the software

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

- Added ffmpeg to PATH
- Added Hausken as maintainer
@pbsbot
Copy link

pbsbot commented Sep 29, 2024

Result of nixpkgs-review pr 345303 run on x86_64-linux 1

2 packages built:
  • twitch-dl
  • twitch-dl.dist

@pbsds
Copy link
Member

pbsds commented Sep 29, 2024

confirmed the wrapping works

@pbsds pbsds merged commit d71c24c into NixOS:master Sep 29, 2024
31 checks passed
@hauskens hauskens deleted the twitch-dl branch September 29, 2024 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants