-
-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
geos: 3.12.2 -> 3.13.0 #344310
base: master
Are you sure you want to change the base?
geos: 3.12.2 -> 3.13.0 #344310
Conversation
Actually putting that back to draft, because it is useless to review before |
Result of 10 packages marked as broken and skipped:
258 packages failed to build:
55 packages built:
|
Result of 10 packages marked as broken and skipped:
201 packages failed to build:
112 packages built:
|
@autra , are you able to paste some nixpkgs-review logs to see why so many packages are broken by this PR ? |
Just tried to build gdal with this PR and it fails on following tests:
|
This patch is fixing GDAL tests issue
@autra , would you please add it to this PR so we can try to run nixpkgs-review once again ? |
Ah, I closed the console, silly me. But starting by fixing gdal is probably the way to go indeed :-) I will add your patch and test again. Btw, do you know why django depends on geos and gdal and if we can prevent this? This makes geos impact more packages that it needs to (for instance authentik has nothing to do with GIS). |
|
|
Result of 10 packages marked as broken and skipped:
180 packages failed to build:
133 packages built:
|
Here are some relevant (I think) logs: python312Packages.psycopg=================================== FAILURES =================================== aconn_cls = <class 'psycopg.AsyncConnection'>
�[1m�[31mE assert 0 == 1�[0m �[1m�[31mtests/test_notify_async.py�[0m:171: AssertionError conn = <psycopg.Connection [IDLE] (database=psycopg) at 0x7fff6f525670>
�[1m�[31mE assert (1727268923.519567 - 1727268918.354055) < 1.0�[0m �[1m�[31mtests/test_concurrency_async.py�[0m:273: AssertionError python311Packages.gdal logs=================================== FAILURES ===================================
�[1m�[31m/build/source/build/autotest/gcore/vsiaz.py�[0m:700: self = <[AttributeError("'Failed' object has no attribute 'msg'") raised in repr()] Failed object at 0x7fff5a5ffe80>
�[1m�[31mE TypeError: Failed expected string as 'msg' parameter, got 'int' instead.�[0m �[1m�[31m/nix/store/80fi9yhb3ln1wnpgf8k2vp98399gj0xz-python3.11-pytest-8.3.2/lib/python3.11/site-packages/_pytest/outcomes.py�[0m:28: TypeError |
librasterlite2
/nix/store/izpf49b74i15pcr9708s3xdwyqs4jxwl-bash-5.2p32/bin/bash ../libtool --tag=CC --mode=link gcc -I/nix/store/47daasc6dlfxfbivdpr8fq0mig0pnnna-libpng-apng-1.6.43-dev/include/libpng16 -I/nix/store/nj3grvd1g7njfzxzmw07ca17sbi354yy-libwebp-1.4.0/include -I/nix/store/6p9vgh2yrz6r3ga7k6xk4rr1xgvgck16-xz-5.6.2-dev/include -I/nix/store/1ksdff0vx376dg1cjjkri19wba4r6ipk-lz4-1.9.4-dev/include -I/nix/store/yv8ksqj4pmpxcq8878hn07nirh6mn5d4-zstd-1.5.6-dev/include -I/nix/store/a06n8yn58k44006a1706hi11cr8ag7yv-openjpeg-2.5.2-dev/include/openjpeg-2.5 -I/nix/store/a49si5nv16sy1jaabryasl015w3s52rr-curl-8.9.1-dev/include -I/nix/store/v40g7q9zix1ycpyara08brd50m00471n-libxml2-2.13.3-dev/include/libxml2 -I/nix/store/zblms4zl9zl27apixxn6zpikmhp9l9qm-fontconfig-2.15.0-dev/include -I/nix/store/aq7h7siccpba7vl7yxhh3fb4s1f1v9vm-freetype-2.13.2-dev/include/freetype2 -I/nix/store/aq7h7siccpba7vl7yxhh3fb4s1f1v9vm-freetype-2.13.2-dev/include/freetype2 -I/nix/store/ykzlrlb2zvz4qsngr16bv2140f637rd2-pixman-0.43.4/include/pixman-1 -I/nix/store/kar6nif5yf3hb0s8dlyhlgrcm2zqg5bs-cairo-1.18.0-dev/include/cairo -I/nix/store/aq7h7siccpba7vl7yxhh3fb4s1f1v9vm-freetype-2.13.2-dev/include/freetype2 -I/nix/store/aq7h7siccpba7vl7yxhh3fb4s1f1v9vm-freetype-2.13.2-dev/include -I/nix/store/sp7x45hin1z2awpqy2yszcxv2bclsjpj-libspatialite-5.1.0-dev/include -g -O2 -L../src -o rl2sniff rl2sniff.o -L/nix/store/mp79jmmfs2bfjmnac72c1kxn7im1px38-libpng-apng-1.6.43/lib -lpng16 -L/nix/store/nj3grvd1g7njfzxzmw07ca17sbi354yy-libwebp-1.4.0/lib -lwebp -L/nix/store/4w3c2c11j2kmwxrznji2i7is53z5aldi-xz-5.6.2/lib -llzma -L/nix/store/ncicdi7m3nw0r1ygyv8ikddc7wlhkzdy-lz4-1.9.4-lib/lib -llz4 -L/nix/store/nf18v7rmqfb90qmd73i8q8ijc99j72mj-zstd-1.5.6/lib -lzstd -L/nix/store/pvqh03iwjx7rqzlrgj2jps2gldsbml5a-openjpeg-2.5.2/lib -lopenjp2 -L/nix/store/x6ssc2mmx1kb52gchksqbzg5c2y0z7lf-curl-8.9.1/lib -lcurl -L/nix/store/nr8mh99sfsb1gw1b1qmrwhzmxbhj84j7-libxml2-2.13.3/lib -lxml2 -L/nix/store/8vi4i41i9w86i3hc925lb2n6r0css4ih-fontconfig-2.15.0-lib/lib -L/nix/store/p1ackxjqznm2q5dl3r178wp487q86jig-freetype-2.13.2/lib -lfontconfig -lfreetype -L/nix/store/p1ackxjqznm2q5dl3r178wp487q86jig-freetype-2.13.2/lib -lfreetype -L/nix/store/ykzlrlb2zvz4qsngr16bv2140f637rd2-pixman-0.43.4/lib -lpixman-1 -L/nix/store/jrl7mpkkl5zh0dpkrh31y3s5svg3z7ay-cairo-1.18.0/lib -lcairo -L/nix/store/8627wpd4mbygb4p5ikzy7whvqhclqnc4-libspatialite-5.1.0/lib -L/nix/store/pnqij3hllcjv2gswq93x1ka6zadsm3vs-geos-3.13.0/lib -L/nix/store/c43jks4q45xikmb8vbnx8zhss98lj3z5-libxml2-2.13.3/lib -L/nix/store/g2i5j8i0bwfih7hg2wbc15k2969bckn3-sqlite-3.46.0/lib -lspatialite -lminizip -lrttopo -lfreexl -lproj -lz -lgeos_c -lxml2 -lsqlite3 -lm -lrasterlite2 -lminizip -lproj -lgeotiff -ltiff -lgif -ljpeg -lz -lsqlite3 |
I think fixing these 3 should fix most of the others. |
gdal failure looks a lot like #302137 (comment) I've just built locally and it passed. Either we wait for next release or we add some more patches ;-) (gdal is released roughly once a month apparently) |
@autra , I just pushed fix for librasterlite2. This build failure wasn't related to this PR. |
python311Packages.gdal error looks like flaky test. |
Result of 10 packages marked as broken and skipped:
68 packages failed to build:
245 packages built:
|
Result of 12 packages marked as broken and skipped:
69 packages failed to build:
250 packages built:
|
Already a bit better! apacheHttpdPackages.mod_tile does build correctly with nix-build. The logs indicate a timeout on my machine when using nixpkgs-review... |
MMhh psycopg also builds correctly when using nix-build alone. The failure with nixpkgs-review is :
They have a timeout of 0 in tests... My bet is that it doesn't work if the machine is under load (which is the case with nixpkgs-review). |
I'll make some tests and I'll open an issue once I'm sure of this. |
Result of 12 packages marked as broken and skipped:
103 packages failed to build:
216 packages built:
|
Result of 10 packages marked as broken and skipped:
23 packages failed to build:
290 packages built:
|
I'll extract the adoption commits in their own PR before putting that to ready. |
a5e6fb7
to
aa4b7b4
Compare
Well gmt seems already broken on master. |
c28001b
to
49a4110
Compare
It seems that all the other packages are broken on master as well. |
49a4110
to
12aa98e
Compare
12aa98e
to
521dab7
Compare
Description of changes
geos: 3.12.2 -> 3.13.0
Let's be optimistic about this ;-)
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.