Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

superhtml: init at 0.5.0 #343878

Merged
merged 2 commits into from
Sep 29, 2024
Merged

superhtml: init at 0.5.0 #343878

merged 2 commits into from
Sep 29, 2024

Conversation

petertriho
Copy link
Contributor

@petertriho petertriho commented Sep 23, 2024

Description of changes

Adds superhtml #340482

I don't use zig and have never packaged any zig projects before so I'm not sure if this the correct way to do things.

zon2nix doesn't work with superhtml so I just manually made the deps.nix file.

@matdibu @callumio

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@petertriho
Copy link
Contributor Author

petertriho commented Sep 23, 2024

Switched to fetchgit for deps that were originally git in build.zig.zon files

@petertriho petertriho force-pushed the superhtml branch 2 times, most recently from e42636b to 48c9e7d Compare September 25, 2024 01:40
@petertriho
Copy link
Contributor Author

@NotAShelf @wegank Is this anything else I need to do to get this merged?

@wegank wegank merged commit cde20f0 into NixOS:master Sep 29, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants