Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arti: move to by-name, modernize derivation and add rapiteanu as maintainer #343720

Merged
merged 4 commits into from
Sep 29, 2024

Conversation

Steinhagen
Copy link
Contributor

@Steinhagen Steinhagen commented Sep 22, 2024

Description of changes

Things done

  1. Removed with lib; (ref: Tracking issue: remove overuses of with lib; #208242)
  2. Formatted via nixfmt-rfc-style
  3. Moved to pkgs/by-name
  4. Add rapiteanu as maintainer
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Steinhagen Steinhagen changed the title arti: move to by-name and modernize derivation arti: move to by-name, modernize derivation and add rapiteanu as maintainer Sep 28, 2024
@wegank wegank merged commit 61e26f8 into NixOS:master Sep 29, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants