Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pinocchio: deactivate one failing test under aarch64-linux #317869

Merged
merged 1 commit into from
Jun 8, 2024

Conversation

nim65s
Copy link
Contributor

@nim65s nim65s commented Jun 7, 2024

Description of changes

Disable one failing test-cpp-algorithm-utils-force on aarch64-linux

ref. #315303 (comment)
ref. stack-of-tasks/pinocchio#2277
cc. @wegank

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot requested a review from wegank June 7, 2024 01:15
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Jun 7, 2024
@ofborg ofborg bot requested a review from wegank June 7, 2024 12:26
@kirillrdy
Copy link
Member

@nim65s second commit doesn't comply commit conventions, can you either update commit message or squash commits ?

Co-authored-by: kirillrdy <[email protected]>
Co-authored-by: Weijia Wang <[email protected]>
@nim65s
Copy link
Contributor Author

nim65s commented Jun 8, 2024

Thanks, done

@ofborg ofborg bot requested a review from wegank June 8, 2024 19:55
@kirillrdy kirillrdy merged commit b86e12c into NixOS:master Jun 8, 2024
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants