-
-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
okonomiyaki: Mark as broken on Python 3.12 #314561
Conversation
Is it just a problem with the test code? Or is it also a problem with the library itself? |
There are three problems.
If it was only the problem that assertRaisesRegexP is deprecated I would’ve provided a patch to replace it with assertRaisesRegex. |
Successfully created backport PR for |
Description of changes
Multiple test are failing on Python 3.12, some due to deprecated unittest.assertRaisesRegexP and some for other reasons.
log.txt
In addition the dependency zipfile2 is broken so it won’t build anyway, even with working tests.
#ZurichZHF
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.