Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

okonomiyaki: Mark as broken on Python 3.12 #314561

Merged
merged 1 commit into from
May 26, 2024

Conversation

Nebucatnetzer
Copy link
Contributor

@Nebucatnetzer Nebucatnetzer commented May 25, 2024

Description of changes

Multiple test are failing on Python 3.12, some due to deprecated unittest.assertRaisesRegexP and some for other reasons.
log.txt

In addition the dependency zipfile2 is broken so it won’t build anyway, even with working tests.

#ZurichZHF

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Nebucatnetzer Nebucatnetzer added 0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign backport release-24.05 Backport PR automatically labels May 25, 2024
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels May 25, 2024
@Nebucatnetzer
Copy link
Contributor Author

@natsukium
Copy link
Member

some due to deprecated unittest.assertRaisesRegexP and some for other reasons.

Is it just a problem with the test code? Or is it also a problem with the library itself?
If only the test code is incompatible with python312, then I would suggest disabling the test.

@Nebucatnetzer
Copy link
Contributor Author

some due to deprecated unittest.assertRaisesRegexP and some for other reasons.

Is it just a problem with the test code? Or is it also a problem with the library itself? If only the test code is incompatible with python312, then I would suggest disabling the test.

There are three problems.

  • The dependency zipfile2 is broken so it won’t build anyway.
  • Tests with assertRaisesRegexP fail.
  • And if you fix those additional tests fail.

If it was only the problem that assertRaisesRegexP is deprecated I would’ve provided a patch to replace it with assertRaisesRegex.
The additional errors for failed tests are in the attached log file but since it won’t build without zipfile2 anyway I didn’t felt like looking into them and reported all of the issues upstream.

@nbraud nbraud merged commit a8dfb82 into NixOS:master May 26, 2024
27 checks passed
Copy link
Contributor

Successfully created backport PR for release-24.05:

Sobte pushed a commit to Sobte/nixpkgs that referenced this pull request May 28, 2024
florian-sanders-cc pushed a commit to florian-sanders-cc/nixpkgs that referenced this pull request Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign 6.topic: python 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux backport release-24.05 Backport PR automatically
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants