mindustry: unbreak

[Mindavi]

Motivation for this change

This should fix:

• Mindustry: Fails to build on NixOS 21.05 #128929 (but then for 21.11)
• Mindustry fails to start #109798.

jdk15 is not supported anymore by oracle / openjdk, but since it's just a game, I don't expect that's a big issue in practice.

I think propagating it like this is the right way to go about it, but please let me know if that seems wrong (and I'd like to hear the proper solution too then). I might have misunderstood how it works, but this seems like a good workaround to me.

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• Fits CONTRIBUTING.md.

[legendofmiracles]

Result of nixpkgs-review pr 146557 run on x86_64-linux 1

2 packages built:

• mindustry
• mindustry-wayland

[fgaz]

Looks good and works for me!

[nixos-discourse]

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/414

[symphorien]

nix-review fails with

error: anonymous function at /home/symphorien/.cache/nixpkgs-review/pr-146557/nixpkgs/pkgs/games/mindustry/default.nix:1:1 called with unexpected argument 'jdk'

       at /home/symphorien/.cache/nixpkgs-review/pr-146557/nixpkgs/lib/customisation.nix:69:16:

           68|     let
           69|       result = f origArgs;
             |                ^
           70|
(use '--show-trace' to show detailed location information)

[Mindavi]

I think I've fixed this locally. It was due to this: #119444, where the jdk was changed to jdk11 (which doesn't work at all for mindustry). Will test the builds and fix it.

[Mindavi]

Builds are not done yet, but this should be ok now. Builds succeeded. I also forgot to do the change for mindustry-server, that's done now too.

Tested all binaries again, they appear to run fine.

[SuperSandro2000]

Suggested change

	glewlib=${lib.getLib glew}/lib/libGLEW.so
	sdllib=${lib.getLib SDL2}/lib/libSDL2.so

[SuperSandro2000]

Suggested change

	--add-needed $glewlib \
	--add-needed $sdllib
	--add-needed ${lib.getLib glew}/lib/libGLEW.so \
	--add-needed ${lib.getLib SDL2}/lib/libSDL2.so

[github-actions]

Backport failed for release-21.11, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin release-21.11
git worktree add -d .worktree/backport-146557-to-release-21.11 origin/release-21.11
cd .worktree/backport-146557-to-release-21.11
git checkout -b backport-146557-to-release-21.11
ancref=$(git merge-base e4562b5e0ac5f32415e3ecc8017b31b5d5cf46db 9e58e392a463a5e0c6585e179746b20f138054f7)
git cherry-pick -x $ancref..9e58e392a463a5e0c6585e179746b20f138054f7

[fgaz]

Unfortunately I don't have much time to backport manually. Pinging people who might be interested: @maxhbr @Mindavi @petabyteboy