Name: use explicit ABI version of webkitgtk #629
Conversation
|
I think the versions without a version specifier should always resolve to the generic attribute (which isn't being removed in nixpkgs, right?). We can still (semi-temporarily) pin it to a fixed version via |
From my understanding the default version might be erroneous since it is not the webkitgtk version but the ABI version witch incompatibilities between them (gtk3 vs gtk4 between 4_0 and 6_0 and libsoup2 vs libsoup3 between 4_0 and 4_1/6_0) And the idea would be to remove the default alias. :c |
|
Removing the default alias and adding versioned names is kinda pointless. This is not an API which hackage packages adhere to, this is a map we maintain to react to whatever hackage packages do. Are there cabal files on hackage which use those versioned attributes? My guess is no. The purpose of this map is imo, that the derivation expects a system library as input under the name which we use in nixpkgs. I agree with sterni, unless the version is already contained in the name used in the cabal file we should override the version in nixpkgs. |
sternenseemann
force-pushed
the
webkitgtk_explicit_abi
branch
from
936088e
to
bb478d3
Compare
When we don't know the exact version from the cabal file, we still emit the generic name that has recently been removed from nixpkgs safe for an alias (NixOS/nixpkgs#345611) which we can't use in hackage-packages.nix. This is still the best solution for downstream expressions generated by cabal2nix, in nixpkgs we'll have to manually specify the correct version (instead of hackage2nix picking the default which may not always be correct). Co-authored-by: sternenseemann <[email protected]>
sternenseemann
force-pushed
the
webkitgtk_explicit_abi
branch
from
bb478d3
to
f32c64b
Compare
|
@sternenseemann Just out of curiosity, do you know whether there actually are cabal files which use the versioned package names? |
|
@maralorn NixOS/nixpkgs@212b040. Any serious project should, frankly. If they use pkg-config, they are forced to (I think). |
|
Ah, okay. Great, thank you! |
Context / Related to: NixOS/nixpkgs#345611