Inverted without_sales_orders filter that had a missing NOT

Nitrokey · Sep 23, 2024 · f5b1a81 · f5b1a81
1 parent c7937f6
commit f5b1a81
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 2 deletions.
diff --git a/merge_duplicate_contacts/models/res_partner.py b/merge_duplicate_contacts/models/res_partner.py
@@ -45,7 +45,6 @@ def open_wizard_action(self):
             raise UserError(
                 _("At least two records are needed to perform this action.")
             )
-            return
         context = {}
         data = self.prepare_wizard_data()
         wizard = self.env["base.partner.merge.automatic.wizard"].create(data)

diff --git a/merge_duplicate_contacts/wizard/merge_contact.py b/merge_duplicate_contacts/wizard/merge_contact.py
@@ -192,7 +192,7 @@ def _generate_query(self, fields, maximum_group=100):
         if self.without_sales_orders:
             where_queries.append(
                 """
-                    id IN
+                    id NOT IN
                     (
                         SELECT partner_id FROM sale_order
                         UNION