Use dataclasses for add_key #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #91 +/- ##
==========================================
+ Coverage 79.99% 80.00% +0.01%
==========================================
Files 751 751
Lines 13333 13340 +7
==========================================
+ Hits 10666 10673 +7
Misses 2667 2667 ☔ View full report in Codecov by Sentry. |
This patch introduces the RsaPrivateKey and GenericPrivateKey dataclasses for the add_key method to make it possible to enforce that exactly only one type of private key is provided using typing. Fixes: #45
robin-nitrokey
force-pushed
the
add-key
branch
from
2a9d32a
to
7bff595
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch introduces the RsaPrivateKey and GenericPrivateKey dataclasses for the add_key method to make it possible to enforce that exactly only one type of private key is provided using typing.
Fixes: #45