Refactor get_key and Key #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robin-nitrokey
force-pushed
the
get-key
branch
from
422812e
to
65d4e6b
Compare
This patch refactors get_key and Key to make it easier to use: - tags is changed from an Optional[list[str]] to a list[str] that is empty if no tags are set. - modulus, public_exponent and data are moved into the RsaPublicKey and EcPublicKey dataclasses so that only the fields for the selected key type are used. Fixes: #88
robin-nitrokey
force-pushed
the
get-key
branch
from
65d4e6b
to
66429a7
Compare
|
The test cases should be expanded to also cover EC and Generic keys. |
|
→ #100 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch refactors get_key and Key to make it easier to use:
Fixes: #88