Mark helpers with underscore prefix #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #87 +/- ##
=======================================
Coverage 79.98% 79.98%
=======================================
Files 751 751
Lines 13303 13303
=======================================
Hits 10640 10640
Misses 2663 2663 ☔ View full report in Codecov by Sentry. |
This patch adds an underscore prefix to all helper methods to indicate that they are not part of the public API. Fixes: #78
robin-nitrokey
force-pushed
the
helpers
branch
from
0fae14b
to
b8145bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds an underscore prefix to all helper methods to indicate that they are not part of the public API.
Fixes: #78