Use enums instead of literals #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robin-nitrokey
requested review from
daringer,
szszszsz,
sosthene-nitrokey and
q-nk
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #81 +/- ##
==========================================
- Coverage 79.54% 79.43% -0.12%
==========================================
Files 751 751
Lines 13255 13292 +37
==========================================
+ Hits 10544 10558 +14
- Misses 2711 2734 +23 ☔ View full report in Codecov by Sentry. |
Using enums makes it easier to use the functions in a typesafe way and to validate user input. Fixes: #69
robin-nitrokey
force-pushed
the
enums
branch
from
f28c8c5
to
23eb940
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using enums makes it easier to use the functions in a typesafe way and to validate user input.
Fixes: #69