tests: Don’t check exact build tag length (#103)

Instead of requiring that the length of the build tag is exactly 7, we
only ensure that it is at least 4.  The exact length of the build tag
depends on the current version number and whether it is build directly
from a tag.

tests/conftest.py

@@ -45,7 +45,6 @@ class Constants:
     FIRMWARE_VERSION = "N/A"
     SOFTWARE_VERSION = "0.9"
     HARDWARE_VERSION = "N/A"
-    BUILD_TAG_LEN = 7
 
     # test_nethsm_users, test_nethsm_config
     UNLOCK_PASSPHRASE_CHANGED = "unlockiunlocki"

tests/test_nethsm_system.py

@@ -35,17 +35,13 @@ def test_provision_system_info(nethsm: NetHSM) -> None:
     """Get system information for a NetHSM instance.
 
     This command requires authentication as a user with the Administrator
-    role.
-    TODO: do not rely on string constants, as nethsm:testing version changes
-    """
+    role."""
     info = nethsm.get_system_info()
-    assert type(info.firmware_version) is str
-    assert type(info.software_version) is str
-    assert type(info.hardware_version) is str
-    assert type(info.build_tag) is str
-    assert len(info.build_tag) == C.BUILD_TAG_LEN
-
-    # fixme: this changes between the NetHSM instances
+    assert len(info.firmware_version) > 0
+    assert len(info.software_version) > 0
+    assert len(info.hardware_version) > 0
+    # build tag should be vx.y with an optional suffix, so at least length 4
+    assert len(info.build_tag) >= 4
 
 
 def test_passphrase_add_user_retrieve_backup(nethsm: NetHSM) -> None: