Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ensure Python 3.11 >= requirement is met for create-venv.sh #13

Merged
merged 1 commit into from
Apr 29, 2024
Merged

fix: ensure Python 3.11 >= requirement is met for create-venv.sh #13

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 17 additions & 4 deletions packages/nillion/create-venv.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,22 +1,35 @@
#!/usr/bin/env bash

PYTHON_MAJOR_MINOR_VERSION=""

function check_python_version() {
required_version="3.11"
current_version=$(python3 --version | cut -d ' ' -f2)
PYTHON_MAJOR_MINOR_VERSION=$(echo $current_version | cut -d '.' -f1,2)
if ! printf '%s\n' "$required_version" "$current_version" | sort -V | head -n 1 | grep -qx "$required_version"; then
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain what's going on on this line because I'm wondering if it can simplified with if [ "$required_version" != "$PYTHON_MAJOR_MINOR_VERSION" ]?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh nevermind. I think the error message below clarifies it. It's the "or higher" part that does it.

echo "This script requires Python ${required_version} or higher. You are running Python $current_version."
exit 1
fi
}

function create_venv () {
if [[ ! -z "${VIRTUAL_ENV:-}" ]]; then
echo "Virtualenv is already active! Run 'deactivate' to deactivate the virtualenv."
return 0
fi

echo "Creating virtualenv"
python3.11 -m pip install install --user virtualenv==20.24.6
python3 -m pip install --user virtualenv==20.24.6

NILLION_VENV=".venv"
mkdir -p "$NILLION_VENV"
python3.11 -m virtualenv -p python3.11 "$NILLION_VENV"
python3 -m virtualenv -p python3 "$NILLION_VENV"
source "$NILLION_VENV/bin/activate"
python3.11 -m pip install -r requirements.txt
python3 -m pip install -r requirements.txt

echo "Virtualenv: $NILLION_VENV"
echo "Check the $NILLION_VENV/lib/python3.11/site-packages folder to make sure you have py_nillion_client and nada_dsl packages"
echo "Check the $NILLION_VENV/lib/python${PYTHON_MAJOR_MINOR_VERSION}/site-packages folder to make sure you have py_nillion_client and nada_dsl packages"
}

check_python_version
create_venv
Loading