Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for #114 #115

Merged
merged 6 commits into from
Nov 11, 2024
Merged

Conversation

dannymeijer
Copy link
Member

@dannymeijer dannymeijer commented Nov 8, 2024

Description

Changed spark.sql.connect behavior to allow for non-connect spark versions to work normally.

Related Issue

#114

Motivation and Context

...

How Has This Been Tested?

Screenshots (if appropriate):

Running SE tests as part of Koheesio, confirms that problem is solved:
image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@dannymeijer dannymeijer linked an issue Nov 8, 2024 that may be closed by this pull request
@dannymeijer dannymeijer marked this pull request as ready for review November 8, 2024 23:12
@dannymeijer dannymeijer added the bug Something isn't working label Nov 8, 2024
Copy link
Collaborator

@asingamaneni asingamaneni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the bug fix

@asingamaneni asingamaneni merged commit f83e469 into main Nov 11, 2024
4 checks passed
@asingamaneni asingamaneni deleted the bug/114-connect-dataframe-not-available-error branch November 11, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants