Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

90-Bug-fix-file-encoding-box-integration #96

Merged
merged 1 commit into from
Nov 8, 2024
Merged

90-Bug-fix-file-encoding-box-integration #96

merged 1 commit into from
Nov 8, 2024

Conversation

louis-paulvlx
Copy link

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@louis-paulvlx louis-paulvlx requested a review from a team as a code owner November 8, 2024 14:25
@dannymeijer dannymeijer changed the base branch from release/0.9 to main November 8, 2024 14:27
@dannymeijer dannymeijer added the bug Something isn't working label Nov 8, 2024
@dannymeijer dannymeijer added this to the 0.9.0 milestone Nov 8, 2024
@dannymeijer dannymeijer changed the base branch from main to release/0.9 November 8, 2024 14:28
dannymeijer
dannymeijer approved these changes Nov 8, 2024
View reviewed changes
Copy link
Member

@dannymeijer dannymeijer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dannymeijer dannymeijer merged commit b37a302 into Nike-Inc:release/0.9 Nov 8, 2024
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dannymeijer dannymeijer dannymeijer approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
Koheesio
Status: Done
Milestone
0.9.0
Development

Successfully merging this pull request may close these issues.
2 participants
@louis-paulvlx @dannymeijer