Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(evm): converted untyped event to typed and cleaned up #2053

Merged
merged 7 commits into from
Oct 3, 2024

chore: cosmetic fixes

2cc64b8
Select commit
Loading
Failed to load commit list.
Merged

refactor(evm): converted untyped event to typed and cleaned up #2053

chore: cosmetic fixes
2cc64b8
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 3, 2024 in 1s

65.13% (target 60.00%)

View this Pull Request on Codecov

65.13% (target 60.00%)

Details

Codecov Report

Attention: Patch coverage is 49.78355% with 116 lines in your changes missing coverage. Please review.

Project coverage is 65.13%. Comparing base (fa62d35) to head (2cc64b8).

Files with missing lines Patch % Lines
x/evm/events.go 0.00% 51 Missing ⚠️
eth/rpc/events_parser.go 53.57% 34 Missing and 5 partials ⚠️
x/evm/keeper/msg_server.go 81.25% 6 Missing and 6 partials ⚠️
eth/rpc/backend/tx_info.go 0.00% 5 Missing ⚠️
eth/rpc/backend/utils.go 66.66% 2 Missing and 2 partials ⚠️
eth/rpc/backend/blocks.go 40.00% 2 Missing and 1 partial ⚠️
eth/rpc/rpcapi/eth_filters_api.go 0.00% 1 Missing ⚠️
x/evm/msg.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2053      +/-   ##
==========================================
- Coverage   65.45%   65.13%   -0.32%     
==========================================
  Files         268      269       +1     
  Lines       16985    17007      +22     
==========================================
- Hits        11117    11078      -39     
- Misses       4941     5000      +59     
- Partials      927      929       +2     
Files with missing lines Coverage Δ
app/evmante/evmante_emit_event.go 100.00% <100.00%> (ø)
eth/indexer/evm_tx_indexer.go 65.11% <ø> (ø)
eth/rpc/rpcapi/filter_utils.go 12.50% <100.00%> (-2.00%) ⬇️
eth/rpc/rpcapi/eth_filters_api.go 4.95% <0.00%> (ø)
x/evm/msg.go 65.25% <0.00%> (-0.39%) ⬇️
eth/rpc/backend/blocks.go 52.09% <40.00%> (-1.30%) ⬇️
eth/rpc/backend/utils.go 65.98% <66.66%> (+0.23%) ⬆️
eth/rpc/backend/tx_info.go 46.66% <0.00%> (-0.40%) ⬇️
x/evm/keeper/msg_server.go 74.22% <81.25%> (-0.65%) ⬇️
eth/rpc/events_parser.go 53.57% <53.57%> (ø)
... and 1 more