Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(evm): Combine both account queries into "/eth.evm.v1.Query/EthAccount", accepting both nibi-prefixed Bech32 addresses and Ethereum-type hexadecimal addresses as input. #1986

Merged
merged 27 commits into from
Aug 6, 2024

Merge branch 'ud/attonibi' into ud/account-query

13c6ae9
Select commit
Loading
Failed to load commit list.
Merged
Codecov / codecov/project succeeded Aug 6, 2024 in 0s

65.75% (target 60.00%)

View this Pull Request on Codecov

65.75% (target 60.00%)

Details

Codecov Report

Attention: Patch coverage is 72.50000% with 11 lines in your changes missing coverage. Please review.

Project coverage is 65.75%. Comparing base (cbb14ba) to head (13c6ae9).

Files Patch % Lines
x/evm/query.go 41.17% 10 Missing ⚠️
x/evm/keeper/gas_fees.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1986      +/-   ##
==========================================
+ Coverage   65.72%   65.75%   +0.03%     
==========================================
  Files         261      261              
  Lines       16528    16529       +1     
==========================================
+ Hits        10863    10869       +6     
+ Misses       4852     4850       -2     
+ Partials      813      810       -3     
Files Coverage Δ
x/evm/evmtest/eth.go 100.00% <ø> (+4.16%) ⬆️
x/evm/keeper/grpc_query.go 83.71% <100.00%> (-0.10%) ⬇️
x/evm/statedb/state_object.go 98.26% <100.00%> (+0.03%) ⬆️
x/evm/keeper/gas_fees.go 27.39% <0.00%> (ø)
x/evm/query.go 8.64% <41.17%> (+3.51%) ⬆️

... and 1 file with indirect coverage changes