feat(eth-rpc): Conversion types and functions between Ethereum txs and blocks and Tendermint ones.

CHANGELOG.md

@@ -54,6 +54,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - [#1838](https://github.com/NibiruChain/nibiru/pull/1838) - feat(eth): Go-ethereum, crypto, encoding, and unit tests for evm/types
 - [#1841](https://github.com/NibiruChain/nibiru/pull/1841) - feat(eth): Collections encoders for bytes, Ethereum addresses, and Ethereum hashes
 - [#1855](https://github.com/NibiruChain/nibiru/pull/1855) - feat(eth-pubsub): Implement in-memory EventBus for real-time topic management and event distribution
+- [#1856](https://github.com/NibiruChain/nibiru/pull/1856) - feat(eth-rpc): Conversion types and functions between Ethereum txs and blocks and Tendermint ones.
 
 #### Dapp modules: perp, spot, oracle, etc
 

cmd/nibid/cmd/root.go

@@ -17,7 +17,7 @@
 	"github.com/cosmos/cosmos-sdk/client/keys"
 	"github.com/cosmos/cosmos-sdk/client/pruning"
 	"github.com/cosmos/cosmos-sdk/client/rpc"
-	"github.com/cosmos/cosmos-sdk/server"
+	sdkserver "github.com/cosmos/cosmos-sdk/server"
 	serverconfig "github.com/cosmos/cosmos-sdk/server/config"
 	servertypes "github.com/cosmos/cosmos-sdk/server/types"
 	authcmd "github.com/cosmos/cosmos-sdk/x/auth/client/cli"
@@ -48,8 +48,9 @@
 		WithViper("") // In simapp, we don't use any prefix for env variables.
 
 	rootCmd := &cobra.Command{
-		Use:   "nibid",
-		Short: "Nibiru app",
+		Use:     "nibid",
+		Short:   "Nibiru blockchain node CLI",
+		Aliases: []string{"nibiru"},
 		PersistentPreRunE: func(cmd *cobra.Command, _ []string) error {
 			cmd.SetOut(cmd.OutOrStdout())
 			cmd.SetErr(cmd.ErrOrStderr())
@@ -74,7 +75,7 @@
 			customAppTemplate, customAppConfig := initAppConfig()
 			tmCfg := customTendermintConfig()
 
-			return server.InterceptConfigsPreRunHandler(
+			return sdkserver.InterceptConfigsPreRunHandler(
 				cmd,
 				customAppTemplate,
 				customAppConfig,
@@ -147,7 +148,7 @@
 		pruning.PruningCmd(a.newApp),
 	)
 
-	server.AddCommands(rootCmd, app.DefaultNodeHome, a.newApp, a.appExport, addModuleInitFlags)
+	sdkserver.AddCommands(rootCmd, app.DefaultNodeHome, a.newApp, a.appExport, addModuleInitFlags)
 
 	// add keybase, auxiliary RPC, query, and tx child commands
 	rootCmd.AddCommand(
@@ -241,7 +242,7 @@
 
 // newApp is an appCreator
 func (a appCreator) newApp(logger log.Logger, db dbm.DB, traceStore io.Writer, appOpts servertypes.AppOptions) servertypes.Application {
-	baseappOptions := server.DefaultBaseappOptions(appOpts)
+	baseappOptions := sdkserver.DefaultBaseappOptions(appOpts)
 
 	return app.NewNibiruApp(
 		logger, db, traceStore, true,

cmd/nibid/cmd/testnet.go

@@ -45,7 +45,9 @@ var (
 )
 
 // get cmd to initialize all files for tendermint testnet and application
-func testnetCmd(mbm module.BasicManager, genBalIterator banktypes.GenesisBalancesIterator) *cobra.Command {
+func testnetCmd(
+	mbm module.BasicManager, genBalIterator banktypes.GenesisBalancesIterator,
+) *cobra.Command {
 	cmd := &cobra.Command{
 		Use:   "testnet",
 		Short: "Initialize files for a simapp testnet",

eth/types/assert.go → eth/assert.go

@@ -1,5 +1,5 @@
 // Copyright (c) 2023-2024 Nibi, Inc.
-package types
+package eth
 
 import (
 	"bytes"

eth/assert_test.go

@@ -0,0 +1,145 @@
+package eth_test
+
+import (
+	"testing"
+
+	"github.com/ethereum/go-ethereum/common"
+	"github.com/stretchr/testify/require"
+
+	"github.com/NibiruChain/nibiru/eth"
+	"github.com/NibiruChain/nibiru/x/common/testutil"
+)
+
+func TestIsEmptyHash(t *testing.T) {
+	testCases := []struct {
+		name     string
+		hash     string
+		expEmpty bool
+	}{
+		{
+			"empty string", "", true,
+		},
+		{
+			"zero hash", common.Hash{}.String(), true,
+		},
+
+		{
+			"non-empty hash", common.BytesToHash([]byte{1, 2, 3, 4}).String(), false,
+		},
+	}
+
+	for _, tc := range testCases {
+		require.Equal(t, tc.expEmpty, eth.IsEmptyHash(tc.hash), tc.name)
+	}
+}
+
+func TestIsZeroAddress(t *testing.T) {
+	testCases := []struct {
+		name     string
+		address  string
+		expEmpty bool
+	}{
+		{
+			"empty string", "", true,
+		},
+		{
+			"zero address", common.Address{}.String(), true,
+		},
+
+		{
+			"non-empty address", common.BytesToAddress([]byte{1, 2, 3, 4}).String(), false,
+		},
+	}
+
+	for _, tc := range testCases {
+		require.Equal(t, tc.expEmpty, eth.IsZeroAddress(tc.address), tc.name)
+	}
+}
+
+func TestValidateAddress(t *testing.T) {
+	testCases := []struct {
+		name     string
+		address  string
+		expError bool
+	}{
+		{
+			"empty string", "", true,
+		},
+		{
+			"invalid address", "0x", true,
+		},
+		{
+			"zero address", common.Address{}.String(), false,
+		},
+		{
+			"valid address", testutil.NewEthAddr().Hex(), false,
+		},
+	}
+
+	for _, tc := range testCases {
+		err := eth.ValidateAddress(tc.address)
+
+		if tc.expError {
+			require.Error(t, err, tc.name)
+		} else {
+			require.NoError(t, err, tc.name)
+		}
+	}
+}
+
+func TestValidateNonZeroAddress(t *testing.T) {
+	testCases := []struct {
+		name     string
+		address  string
+		expError bool
+	}{
+		{
+			"empty string", "", true,
+		},
+		{
+			"invalid address", "0x", true,
+		},
+		{
+			"zero address", common.Address{}.String(), true,
+		},
+		{
+			"valid address", testutil.NewEthAddr().Hex(), false,
+		},
+	}
+
+	for _, tc := range testCases {
+		err := eth.ValidateNonZeroAddress(tc.address)
+
+		if tc.expError {
+			require.Error(t, err, tc.name)
+		} else {
+			require.NoError(t, err, tc.name)
+		}
+	}
+}
+
+func TestSafeInt64(t *testing.T) {
+	testCases := []struct {
+		name     string
+		value    uint64
+		expError bool
+	}{
+		{
+			"no overflow", 10, false,
+		},
+		{
+			"overflow", 18446744073709551615, true,
+		},
+	}
+
+	for _, tc := range testCases {
+		value, err := eth.SafeInt64(tc.value)
+		if tc.expError {
+			require.Error(t, err, tc.name)
+			continue
+		}
+
+		require.NoError(t, err, tc.name)
+		require.Equal(t, int64(tc.value), value, tc.name)
+	}
+}

eth/types/chain_id.go → eth/chain_id.go

@@ -1,5 +1,5 @@
 // Copyright (c) 2023-2024 Nibi, Inc.
-package types
+package eth
 
 import (
 	"fmt"

eth/types/chain_id_test.go → eth/chain_id_test.go

@@ -1,4 +1,4 @@
-package types
+package eth
 
 import (
 	"math/big"
@@ -51,6 +51,9 @@ func TestParseChainID(t *testing.T) {
 		{
 			"invalid eip155 chain-id, cannot invalid base", "nibiru_0x212-1", true, nil,
 		},
+		{
+			"invalid eip155 chain-id, cannot invalid base", "nibiru_1-0x212", true, nil,
+		},
 		{
 			"invalid eip155 chain-id, non-integer", "nibiru_nibiru_9000-1", true, nil,
 		},

eth/types/codec.go → eth/codec.go

@@ -1,25 +1,38 @@
 // Copyright (c) 2023-2024 Nibi, Inc.
-package types
+package eth
 
 import (
 	codectypes "github.com/cosmos/cosmos-sdk/codec/types"
-	"github.com/cosmos/cosmos-sdk/types/tx"
+	sdktx "github.com/cosmos/cosmos-sdk/types/tx"
 	authtypes "github.com/cosmos/cosmos-sdk/x/auth/types"
 )
 
 // RegisterInterfaces registers the tendermint concrete client-related
 // implementations and interfaces.
 func RegisterInterfaces(registry codectypes.InterfaceRegistry) {
+	// proto name: "cosmos.auth.v1beta1.AccountI"
 	registry.RegisterImplementations(
 		(*authtypes.AccountI)(nil),
 		&EthAccount{},
+		// Also impl by: [
+		//   &authtypes.BaseAccount{},
+		//   &authtypes.ModuleAccount{},
+		// ]
 	)
+
+	// proto name: "cosmos.auth.v1beta1.GenesisAccount"
 	registry.RegisterImplementations(
 		(*authtypes.GenesisAccount)(nil),
 		&EthAccount{},
+		// Also impl by: [
+		//   &authtypes.BaseAccount{},
+		//   &authtypes.ModuleAccount{},
+		// ]
 	)
+
+	// proto name: "cosmos.tx.v1beta1.TxExtensionOptionI"
 	registry.RegisterImplementations(
-		(*tx.TxExtensionOptionI)(nil),
+		(*sdktx.TxExtensionOptionI)(nil),
 		&ExtensionOptionsWeb3Tx{},
 		&ExtensionOptionDynamicFeeTx{},
 	)