-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): collections to v0.4.0 for math.Int value encoder #1703
Conversation
WalkthroughThe recent updates involve refactoring and dependency management. Redundant encoders and associated functions have been removed from Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on X ? TipsChat with CodeRabbit Bot (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files ignored due to filter (2)
- go.mod
- go.sum
Files selected for processing (3)
- CHANGELOG.md (1 hunks)
- x/perp/v2/keeper/dnr.go (2 hunks)
- x/perp/v2/keeper/keeper.go (1 hunks)
Files skipped from review due to trivial changes (1)
- CHANGELOG.md
Additional comments: 4
x/perp/v2/keeper/dnr.go (3)
1-6: The import of the
collections
package is correctly updated to presumably use the newmath.Int
value encoder from thecollections
package v0.4.0. Ensure that thecollections
package at this version is compatible with the rest of the codebase and that all necessary migrations from the old encoders to the new ones are complete.10-11: The removal of the
math/big
package import suggests that the newcollections
package handles the functionality previously provided bymath/big
. Verify that all instances wheremath/big
was used are now correctly using thecollections
package and that there are no leftover usages that would require themath/big
package.13-15: The rest of the file appears to be unchanged, which implies that the existing logic and functionality are expected to work with the updated
collections
package. Confirm that the integration of the new encoders from thecollections
package does not require any additional changes to the existing methods and that they are compatible with the rest of the codebase.x/perp/v2/keeper/keeper.go (1)
- 103-122: The changes to the
NewKeeper
function correctly replace the oldIntValueEncoder
andIntKeyEncoder
withcollections.IntValueEncoder
andcollections.IntKeyEncoder
from the updatedcollections
package. This aligns with the PR objectives and the AI-generated overview. Ensure that thecollections
package is indeed updated to v0.4.0 in thego.mod
file to match the PR's intent.
The verification script confirms that the
collections
package has been updated to version v0.4.0 in thego.mod
file, which is consistent with the PR's objective to use the newmath.Int
value encoder from this version. The changes in thekeeper.go
file, replacing the oldIntValueEncoder
andIntKeyEncoder
withcollections.IntValueEncoder
andcollections.IntKeyEncoder
, are also in line with the PR's intent.Final review comment:
The updates to the
NewKeeper
function inkeeper.go
are verified to correctly implement the new encoders from thecollections
package version v0.4.0, as intended by the PR. The dependency version in thego.mod
file matches the PR's objective.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1703 +/- ##
==========================================
- Coverage 73.93% 73.92% -0.02%
==========================================
Files 191 191
Lines 15129 15103 -26
==========================================
- Hits 11186 11165 -21
+ Misses 3289 3285 -4
+ Partials 654 653 -1
|
cosmossdk.io/math.Int
key and value encoder #1678Summary by CodeRabbit
Refactor
Chores
Documentation