Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(sudo): increase unit test coverage #1521

Merged
merged 30 commits into from
Jul 26, 2023
Merged

test(sudo): increase unit test coverage #1521

merged 30 commits into from
Jul 26, 2023

Conversation

commit dc5559c
Author: Unique-Divine <[email protected]>
Date:   Tue Jul 25 20:46:27 2023 -0500

    test(inflation): run the suite

commit d526b2a
Author: Unique-Divine <[email protected]>
Date:   Tue Jul 25 20:36:36 2023 -0500

    linter

commit 062dbfc
Merge: 392d080 e793851
Author: Unique-Divine <[email protected]>
Date:   Tue Jul 25 20:25:22 2023 -0500

    Merge branch 'realu/test-inflation' into realu/test-inflation-2

commit e793851
Author: Unique-Divine <[email protected]>
Date:   Tue Jul 25 20:10:32 2023 -0500

    test(inflation): test getters in params.go

commit 392d080
Author: Unique-Divine <[email protected]>
Date:   Tue Jul 25 19:21:07 2023 -0500

    test(inflation): param set pairs

commit 2aa65ed
Author: Unique-Divine <[email protected]>
Date:   Tue Jul 25 19:01:00 2023 -0500

    refactor(simapp): simapp fns are not used outside the simapp dir or tests

commit 68c47ad
Author: Unique-Divine <[email protected]>
Date:   Tue Jul 25 13:22:01 2023 -0500

    refactor: remove unused fn

commit 8a01ec1
Author: Unique-Divine <[email protected]>
Date:   Tue Jul 25 12:37:34 2023 -0500

    small refactor for better var names

commit d263ffb
Author: Unique-Divine <[email protected]>
Date:   Tue Jul 25 12:07:56 2023 -0500

    changelog

commit aa92edd
Author: Unique-Divine <[email protected]>
Date:   Tue Jul 25 12:06:51 2023 -0500

    deps: remove usage of cosmossdk.io/depinject since it doesn't work outside the cosmos-sdk

commit b774c48
Author: Unique-Divine <[email protected]>
Date:   Tue Jul 25 12:05:47 2023 -0500

    refactor: make it possible to use the encoding config without the app

commit 2e7192a
Author: Unique-Divine <[email protected]>
Date:   Tue Jul 25 10:54:18 2023 -0500

    linter

commit 773dee4
Merge: efac0d8 0c571c6
Author: Unique-Divine <[email protected]>
Date:   Tue Jul 25 10:53:20 2023 -0500

    Merge branch 'master' into realu/test-inflation

commit efac0d8
Author: Unique-Divine <[email protected]>
Date:   Tue Jul 25 10:52:20 2023 -0500

    feat(wasm): no op handler + tests with updated shifter.wasm

commit 2ed7490
Author: Unique-Divine <[email protected]>
Date:   Mon Jul 24 15:45:12 2023 -0500

    test(inflation): types coverage
@Unique-Divine Unique-Divine requested a review from a team as a code owner July 26, 2023 02:31
@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Merging #1521 (1e405b4) into master (0c571c6) will increase coverage by 0.96%.
Report is 2 commits behind head on master.
The diff coverage is 70.70%.

❗ Current head 1e405b4 differs from pull request most recent head 149e575. Consider uploading reports for the commit 149e575 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1521      +/-   ##
==========================================
+ Coverage   65.34%   66.30%   +0.96%     
==========================================
  Files         161      162       +1     
  Lines       14023    13966      -57     
==========================================
+ Hits         9163     9260      +97     
+ Misses       4213     4054     -159     
- Partials      647      652       +5     
Files Changed Coverage Δ
x/epochs/module.go 50.94% <0.00%> (ø)
x/inflation/keeper/grpc_query.go 100.00% <ø> (+85.29%) ⬆️
x/inflation/types/params.go 73.91% <ø> (ø)
x/genmsg/module.go 53.57% <53.57%> (ø)
x/genmsg/genesis.go 68.75% <68.75%> (ø)
app/app.go 64.10% <100.00%> (ø)
app/encoding.go 100.00% <100.00%> (ø)
app/keepers.go 99.06% <100.00%> (+<0.01%) ⬆️
cmd/nibid/cmd/root.go 80.82% <100.00%> (ø)
x/common/testutil/cli/network.go 59.78% <100.00%> (ø)
... and 4 more

... and 5 files with indirect coverage changes

@matthiasmatt matthiasmatt merged commit d736b3d into master Jul 26, 2023
14 checks passed
@matthiasmatt matthiasmatt deleted the realu/test-sudo branch July 26, 2023 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

test: 80%+ keeper coverage for x/sudo | prio: H test: 80%+ keeper coverage for x/inflation | prio: H
2 participants