Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: improve test coverage for type tests in perp v2 #1518

Merged
merged 16 commits into from
Jul 24, 2023

Conversation

matthiasmatt
Copy link
Contributor

Description

What does this PR do?

Purpose

Why is this PR important?

@matthiasmatt matthiasmatt requested a review from a team as a code owner July 24, 2023 10:41
@matthiasmatt matthiasmatt marked this pull request as draft July 24, 2023 10:41
@codecov
Copy link

codecov bot commented Jul 24, 2023

Codecov Report

Merging #1518 (2d27663) into master (4566d9f) will increase coverage by 3.22%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1518      +/-   ##
==========================================
+ Coverage   62.00%   65.23%   +3.22%     
==========================================
  Files         159      159              
  Lines       13914    13969      +55     
==========================================
+ Hits         8628     9112     +484     
+ Misses       4642     4211     -431     
- Partials      644      646       +2     
Impacted Files Coverage Δ
x/common/testutil/cli/network.go 59.78% <100.00%> (ø)
x/inflation/types/params.go 73.91% <100.00%> (ø)
x/perp/v2/types/amm.go 87.55% <100.00%> (+20.59%) ⬆️
x/perp/v2/types/market.go 100.00% <100.00%> (+100.00%) ⬆️
x/perp/v2/types/msgs.go 92.10% <100.00%> (+92.10%) ⬆️
x/perp/v2/types/position.go 100.00% <100.00%> (+100.00%) ⬆️
x/spot/keeper/liquidity.go 59.37% <100.00%> (ø)
x/stablecoin/keeper/needed.go 100.00% <100.00%> (ø)

... and 4 files with indirect coverage changes

@matthiasmatt matthiasmatt marked this pull request as ready for review July 24, 2023 15:57
@matthiasmatt matthiasmatt enabled auto-merge (squash) July 24, 2023 16:39
@matthiasmatt matthiasmatt merged commit 62a165f into master Jul 24, 2023
16 checks passed
@matthiasmatt matthiasmatt deleted the mat/add-perp-tests branch July 24, 2023 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants