Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(oracle): Implement OrderedMap and use it for iterating through maps in x/oracle #1506

Merged
merged 21 commits into from
Jul 24, 2023

Conversation

Unique-Divine
Copy link
Member

No description provided.

@Unique-Divine Unique-Divine requested a review from a team as a code owner July 17, 2023 00:58
Unique-Divine and others added 14 commits July 17, 2023 12:18
Bumps [github.com/CosmWasm/wasmvm](https://github.com/CosmWasm/wasmvm) from 1.2.4 to 1.3.0.
- [Release notes](https://github.com/CosmWasm/wasmvm/releases)
- [Changelog](https://github.com/CosmWasm/wasmvm/blob/main/CHANGELOG.md)
- [Commits](CosmWasm/wasmvm@v1.2.4...v1.3.0)

---
updated-dependencies:
- dependency-name: github.com/CosmWasm/wasmvm
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@Unique-Divine Unique-Divine added the ⚠️ do not merge On hold for merge or not desired label Jul 24, 2023
@codecov
Copy link

codecov bot commented Jul 24, 2023

Codecov Report

Merging #1506 (1738b81) into master (4566d9f) will increase coverage by 3.25%.
The diff coverage is 87.26%.

❗ Current head 1738b81 differs from pull request most recent head d86790b. Consider uploading reports for the commit d86790b to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1506      +/-   ##
==========================================
+ Coverage   62.00%   65.26%   +3.25%     
==========================================
  Files         159      161       +2     
  Lines       13914    14040     +126     
==========================================
+ Hits         8628     9163     +535     
+ Misses       4642     4230     -412     
- Partials      644      647       +3     
Impacted Files Coverage Δ
x/common/omap/omap.go 71.01% <71.01%> (ø)
x/common/omap/impl.go 100.00% <100.00%> (ø)
x/common/testutil/cli/network.go 59.78% <100.00%> (ø)
x/inflation/types/params.go 73.91% <100.00%> (ø)
x/oracle/keeper/ballot.go 93.68% <100.00%> (-0.26%) ⬇️
x/oracle/keeper/update_exchange_rates.go 93.50% <100.00%> (-0.47%) ⬇️
x/perp/v2/types/amm.go 87.55% <100.00%> (+20.59%) ⬆️
x/perp/v2/types/market.go 100.00% <100.00%> (+100.00%) ⬆️
x/perp/v2/types/msgs.go 92.10% <100.00%> (+92.10%) ⬆️
x/perp/v2/types/position.go 100.00% <100.00%> (+100.00%) ⬆️
... and 2 more

... and 4 files with indirect coverage changes

Copy link
Contributor

@matthiasmatt matthiasmatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

func (om *OrderedMap[K, V]) IndexOf(key K) (out *int) panics when an element is missing. it's probably better to fix it to avoid chain halt risk

x/common/omap/impl.go Outdated Show resolved Hide resolved
x/common/omap/omap.go Outdated Show resolved Hide resolved
@Unique-Divine Unique-Divine removed the ⚠️ do not merge On hold for merge or not desired label Jul 24, 2023
@matthiasmatt matthiasmatt merged commit 0c571c6 into master Jul 24, 2023
16 checks passed
@matthiasmatt matthiasmatt deleted the realu/omap branch July 24, 2023 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants