Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(perp): fix RemoveMargin test #1492

Closed
wants to merge 3 commits into from
Closed

test(perp): fix RemoveMargin test #1492

wants to merge 3 commits into from

Conversation

k-yang
Copy link
Member

@k-yang k-yang commented Jul 5, 2023

Description

PositionShouldBeEqual doesn't throw an error if the event is missing from the EventManager, so this PR addresses that. Then I realized that the RemoveMargin test had an extra assertion for checking that a PositionChangedEvent exists when it shouldn't.

Purpose

Fixes perp event assertion testing.

@k-yang k-yang self-assigned this Jul 5, 2023
@k-yang k-yang marked this pull request as ready for review July 5, 2023 17:18
@k-yang k-yang requested a review from a team as a code owner July 5, 2023 17:18
@k-yang k-yang enabled auto-merge (squash) July 5, 2023 20:58
@k-yang k-yang disabled auto-merge July 10, 2023 15:04
@k-yang
Copy link
Member Author

k-yang commented Jul 10, 2023

Already merged in 27c7503

@k-yang k-yang closed this Jul 10, 2023
@Unique-Divine Unique-Divine deleted the fix/perp/event-assertion branch December 19, 2023 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthiasmatt matthiasmatt matthiasmatt approved these changes

Assignees

@k-yang k-yang

Labels
skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@k-yang @matthiasmatt