Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(spot): wire msg service into router #1459

Merged
merged 15 commits into from
Jun 29, 2023
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

### Bug Fixes

* [#1459](https://github.com/NibiruChain/nibiru/pull/1459) - fix(spot): wire `x/spot` msgService into app router

### Dependencies

- Bump `robinraju/release-downloader` from 1.6 to 1.8 (#1326)
Expand Down
13 changes: 5 additions & 8 deletions x/common/testutil/cli/tx.go
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import (
"github.com/cosmos/cosmos-sdk/client/flags"
"github.com/cosmos/cosmos-sdk/client/tx"
"github.com/cosmos/cosmos-sdk/crypto/keyring"
"github.com/cosmos/cosmos-sdk/testutil/cli"
sdktestutil "github.com/cosmos/cosmos-sdk/testutil/cli"
sdk "github.com/cosmos/cosmos-sdk/types"
"github.com/spf13/cobra"

Expand Down Expand Up @@ -92,22 +92,19 @@ func ExecTx(network *Network, cmd *cobra.Command, txSender sdk.AccAddress, args

clientCtx := network.Validators[0].ClientCtx

rawResp, err := cli.ExecTestCLICmd(clientCtx, cmd, args)
rawResp, err := sdktestutil.ExecTestCLICmd(clientCtx, cmd, args)
if err != nil {
return nil, fmt.Errorf("failed to execute tx: %w", err)
}
tmpResp := new(sdk.TxResponse)
err = clientCtx.Codec.UnmarshalJSON(rawResp.Bytes(), tmpResp)
if err != nil {
return nil, fmt.Errorf("failed to unmarshal tx response: %w", err)
}

err = network.WaitForNextBlock()
if err != nil {
return nil, err
}

resp, err := QueryTx(clientCtx, tmpResp.TxHash)
txResp := new(sdk.TxResponse)
clientCtx.Codec.MustUnmarshalJSON(rawResp.Bytes(), txResp)
resp, err := QueryTx(clientCtx, txResp.TxHash)
if err != nil {
return nil, fmt.Errorf("failed to query tx: %w", err)
}
Expand Down
1 change: 0 additions & 1 deletion x/spot/client/testutil/cli_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ import (
)

func TestIntegrationTestSuite(t *testing.T) {
t.SkipNow() // Skipped as it is not binded to the app
coinsFromGenesis := []string{
denoms.NIBI,
denoms.NUSD,
Expand Down
Loading
Loading