feat: add USD price feed support for PriceFeedOracle #1271
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rackstar
force-pushed
the
feat/price-feed-oracle-cbbtc-usd-support
branch
from
75a24a6
to
da2a42c
Compare
rackstar
commented
Oct 25, 2024
rackstar
force-pushed
the
feat/price-feed-oracle-cbbtc-usd-support
branch
5 times, most recently
from
b6addbc
to
6adec8e
Compare
rackstar
force-pushed
the
feat/price-feed-oracle-cbbtc-usd-support
branch
from
6adec8e
to
b8a50fa
Compare
rackstar
force-pushed
the
feat/price-feed-oracle-cbbtc-usd-support
branch
from
b8a50fa
to
c00920e
Compare
shark0der
previously approved these changes
Oct 31, 2024
* add assets getter natspec comments * convert natspec commets to triple slash
rackstar
force-pushed
the
feat/price-feed-oracle-cbbtc-usd-support
branch
from
62aec15
to
c51cd54
Compare
rackstar
force-pushed
the
feat/price-feed-oracle-cbbtc-usd-support
branch
from
4843589
to
c1a9a39
Compare
shark0der
reviewed
Nov 5, 2024
shark0der
reviewed
Nov 5, 2024
shark0der
reviewed
Nov 5, 2024
rackstar
force-pushed
the
feat/price-feed-oracle-cbbtc-usd-support
branch
from
c1a9a39
to
575781b
Compare
shark0der
approved these changes
Nov 5, 2024
rackstar
changed the title
2 tasks
|
closing in favour of: #1275 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #1260
These changes adds support for USD-based price feeds to be converted to ETH rate in PriceFeedOracle.
Context:
We want to onboard cbBTC as a new Pool asset but currently cbBTC does not have an ETH price feed only cbBTC-USD priceFeed. These PriceFeedOracle changes are required so that we can onboard cbBTC as a coverAsset.
Testing
Checklist