Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add semantic commit / branch hooks validation #1248

Open
wants to merge 7 commits into
base: release-candidate
Choose a base branch
from

Conversation

rackstar
Copy link
Contributor

@rackstar rackstar commented Sep 26, 2024

Context

These changes enforces semantic commit (via commitlint dev dependency) and semantic branch name validation

Changes proposed in this pull request

  • modify pre-push hook to only execute tests if PRE_PUSH_RUN_TEST=true
  • add semantic branch naming pre-commit hook
  • add semantic commit commit-msg hook

Test plan

  • manually tested all 3 hooks

Checklist

  • Rebased the base branch
  • Attached corresponding Github issue
  • Prefixed the name with the type of change (i.e. feat, chore, test)
  • Performed a self-review of my own code
  • Followed the style guidelines of this project
  • Made corresponding changes to the documentation
  • Didn't generate new warnings
  • Didn't generate failures on existing tests
  • Added tests that prove my fix is effective or that my feature works

Review

When reviewing a PR, please indicate intention in comments using the following emojis:

  • 🍰 = Nice to have but not essential.
  • 💡 = Suggestion or a comment based on personal opinion
  • 🔨 = I believe this should be changed.
  • 🤔 = I don’t understand something, do you mind giving me more context?
  • 🚀 = Feedback

@rackstar rackstar added the enhancement New feature or request label Sep 26, 2024
@rackstar rackstar self-assigned this Sep 26, 2024
@rackstar rackstar added chore and removed enhancement New feature or request labels Sep 26, 2024
@rackstar rackstar force-pushed the chore/add-semantic-commit-branch-hooks-validation branch from 3c0c807 to 48ec2fa Compare September 27, 2024 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: 👀 In review
Development

Successfully merging this pull request may close these issues.

1 participant