Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: long term limit order for SwapOperator #1230

Merged
merged 12 commits into from
Oct 2, 2024
Merged

feat: long term limit order for SwapOperator #1230

merged 12 commits into from
Oct 2, 2024

Conversation

MilGard91
Copy link
Contributor

Context

Issue: #1218

Changes proposed in this pull request

  • Add a way to track assets that are transfer from the Pool to swapOperator for the orders
  • When calculating eth value of the pool use priceFeedOracle to calculate the value from swapOperator

Test plan

Please describe the tests cases that you ran to verify your changes. Add further instructions on
how to run them if needed (i.e. migration / deployment scripts, env vars, etc).

Checklist

  • Rebased the base branch
  • Attached corresponding Github issue
  • Prefixed the name with the type of change (i.e. feat, chore, test)
  • Performed a self-review of my own code
  • Followed the style guidelines of this project
  • Made corresponding changes to the documentation
  • Didn't generate new warnings
  • Didn't generate failures on existing tests
  • Added tests that prove my fix is effective or that my feature works

Review

When reviewing a PR, please indicate intention in comments using the following emojis:

  • 🍰 = Nice to have but not essential.
  • 💡 = Suggestion or a comment based on personal opinion
  • 🔨 = I believe this should be changed.
  • 🤔 = I don’t understand something, do you mind giving me more context?
  • 🚀 = Feedback

@MilGard91 MilGard91 linked an issue Sep 4, 2024 that may be closed by this pull request
Add support for long timeframe Cowswap limit orders #1218
Closed
@MilGard91 MilGard91 force-pushed the feature/long-term-limit-order branch 5 times, most recently from 061ec70 to c313afb Compare September 6, 2024 07:27
@MilGard91 MilGard91 force-pushed the feature/long-term-limit-order branch 4 times, most recently from 598e1fc to 0500aad Compare September 9, 2024 16:12
@MilGard91 MilGard91 marked this pull request as ready for review September 9, 2024 16:12
@MilGard91 MilGard91 force-pushed the feature/long-term-limit-order branch 2 times, most recently from 17ddc9b to 70847c5 Compare September 16, 2024 06:40
rackstar
rackstar approved these changes Oct 2, 2024
View reviewed changes
Copy link
Contributor

@rackstar rackstar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the audit the feature branch have different commits (due to something being merged in master during audit)

but I compared the contents of Pool and SwapOperator on both branches and they seem to be the same. approving

@rackstar rackstar changed the title feature: long term limit order feat: long term limit order for SwapOperator Oct 2, 2024
@rackstar rackstar merged commit de0fe50 into release-candidate Oct 2, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shark0der shark0der shark0der left review comments

@rackstar rackstar rackstar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for long timeframe Cowswap limit orders
3 participants
@MilGard91 @shark0der @rackstar