Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

W3d4_fix #1075

Merged
merged 7 commits into from
Jul 31, 2023
Merged

W3d4_fix #1075

merged 7 commits into from
Jul 31, 2023

Conversation

GaganaB
Copy link
Collaborator

@GaganaB GaganaB commented Jul 31, 2023

Fixing Issue #1074 and Issue #1073

@github-actions
Copy link

W3D4_Tutorial3
Instructor Open In Colab
Student Open In Colab
Code report for W3D4_Tutorial3

Code report for W3D4_Tutorial3.ipynb

Quality (pyflakes)

Total code issues: 0

Style (pycodestyle)

Total PEP8 violations: 52

Common problems:

  • 11 instances of E231 (missing whitespace after ',')
  • 10 instances of E226 (missing whitespace around arithmetic operator)
  • 9 instances of E402 (module level import not at top of file)
  • 5 instances of E302 (expected 2 blank lines, found 0)
  • 5 instances of E121 (continuation line under-indented for hanging indent)
  • 2 instances of E302 (expected 2 blank lines, found 1)
  • 2 instances of E266 (too many leading '#' for block comment)
  • 1 instance of E501 (line too long (151 > 88 characters))
  • 1 instance of E501 (line too long (101 > 88 characters))
  • 1 instance of E501 (line too long (94 > 88 characters))

@github-actions
Copy link

W3D4_Tutorial1 W3D4_Tutorial3
Instructor Open In Colab Open In Colab
Student Open In Colab Open In Colab
Code report for W3D4_Tutorial1

Code report for W3D4_Tutorial1.ipynb

Quality (pyflakes)

Total code issues: 0

Style (pycodestyle)

Total PEP8 violations: 77

Common problems:

  • 10 instances of E402 (module level import not at top of file)
  • 9 instances of E261 (at least two spaces before inline comment)
  • 8 instances of E251 (unexpected spaces around keyword / parameter equals)
  • 6 instances of E231 (missing whitespace after ',')
  • 6 instances of E225 (missing whitespace around operator)
  • 5 instances of E302 (expected 2 blank lines, found 1)
  • 5 instances of E226 (missing whitespace around arithmetic operator)
  • 4 instances of E703 (statement ends with a semicolon)
  • 3 instances of E302 (expected 2 blank lines, found 0)
  • 3 instances of E305 (expected 2 blank lines after class or function definition, found 0)

Code report for W3D4_Tutorial3

Code report for W3D4_Tutorial3.ipynb

Quality (pyflakes)

Total code issues: 0

Style (pycodestyle)

Total PEP8 violations: 52

Common problems:

  • 11 instances of E231 (missing whitespace after ',')
  • 10 instances of E226 (missing whitespace around arithmetic operator)
  • 9 instances of E402 (module level import not at top of file)
  • 5 instances of E302 (expected 2 blank lines, found 0)
  • 5 instances of E121 (continuation line under-indented for hanging indent)
  • 2 instances of E302 (expected 2 blank lines, found 1)
  • 2 instances of E266 (too many leading '#' for block comment)
  • 1 instance of E501 (line too long (151 > 88 characters))
  • 1 instance of E501 (line too long (101 > 88 characters))
  • 1 instance of E501 (line too long (94 > 88 characters))

@GaganaB GaganaB requested a review from spirosChv July 31, 2023 19:15
Copy link
Collaborator

@spirosChv spirosChv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@spirosChv spirosChv merged commit 7d2a3fe into main Jul 31, 2023
@spirosChv spirosChv deleted the w3d4_fix branch July 31, 2023 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants