Pin Zarr for tests #460
Merged
Pin Zarr for tests #460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@CodyCBakerPhD I fixed the tests so that zarr has an upper bound when the dandi extra is installed and |
|
I believe there was an old reason (so that joint installation requirements are not resolved simultaneously) but since that's working now OK to switch back |
And sure, that's fine. Need to talk about it next LBNL meeting but most likely we'll stop supporting previous PyNWB versions with latest Inspector version |
rly
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Analog of catalystneuro/neuroconv#845 for here as well
Tests just failed today due to a surprise break from Zarr release yesterday - some issue with decoding Blosc
Shouldn't effect actual typical usage of the backend feature aside from Blosc I assume, since none of the other compressor tests complain
hdmf-dev/hdmf-zarr#192 so team knows about it, and if it's an issue with the way they specify the read from the IO level (I doubt it, but never know)
Downpinning in tests temporarily to fix the CI, will check over time if resolved automagically