Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use latest lindi, pynwb, and hdmf with aws_region #59

Merged
merged 25 commits into from
May 20, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
5ad9ec9
Use latest lindi
rly May 17, 2024
9ee1a60
Update to latest pynwb/hdmf
rly May 17, 2024
7c124c5
Add is_staging arg to get_s3_url
rly May 17, 2024
ba8d0f3
Add lindi remote rfs test cases
rly May 17, 2024
cd04a21
Add AWS_REGION, remove load_namespaces
rly May 18, 2024
310f94c
Fix
rly May 18, 2024
7794d75
Add remote slicing params, copy params to network
rly May 18, 2024
987875c
Fix region
rly May 18, 2024
a9ef849
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] May 18, 2024
8792de2
dandi improvement
CodyCBakerPhD May 18, 2024
b187b29
dandi improvement
CodyCBakerPhD May 18, 2024
53c006c
remove from benchmarks
CodyCBakerPhD May 18, 2024
2e9a5fa
some results
CodyCBakerPhD May 18, 2024
28e870e
limit automatic cartesian product
CodyCBakerPhD May 18, 2024
cc5fb73
debug multiparams
CodyCBakerPhD May 18, 2024
6c4eaca
Merge pull request #61 from NeurodataWithoutBorders/improvements
CodyCBakerPhD May 18, 2024
4c293c7
debug multiparams
CodyCBakerPhD May 19, 2024
2b359bf
some results
CodyCBakerPhD May 19, 2024
63c6133
Merge branch 'lindi_update' into debug_params
CodyCBakerPhD May 19, 2024
077a763
almost full results from slice timings
CodyCBakerPhD May 19, 2024
080575c
Merge branch 'debug_params' of https://github.com/neurodatawithoutbor…
CodyCBakerPhD May 19, 2024
4d4c1db
Add dataset generation script
rly May 20, 2024
6108e9e
Merge branch 'lindi_update' into debug_params
CodyCBakerPhD May 20, 2024
3ae2587
Merge pull request #63 from NeurodataWithoutBorders/debug_params
CodyCBakerPhD May 20, 2024
4d25721
Update environments/nwb_benchmarks.yaml
rly May 20, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/writing_benchmarks.rst
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ Notice how the ``read_hdf5_nwbfile_remfile`` function (which reads an HDF5-backe
def read_hdf5_nwbfile_remfile(s3_url: str) -> Tuple[pynwb.NWBFile, pynwb.NWBHDF5IO, h5py.File, remfile.File]:
"""Read an HDF5 NWB file from an S3 URL using the ROS3 driver from h5py."""
(file, byte_stream) = read_hdf5_remfile(s3_url=s3_url)
io = pynwb.NWBHDF5IO(file=file, load_namespaces=True)
io = pynwb.NWBHDF5IO(file=file, aws_region="us-east-2")
nwbfile = io.read()
return (nwbfile, io, file, byte_stream)
Expand Down
7 changes: 3 additions & 4 deletions environments/nwb_benchmarks.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,15 +9,14 @@ dependencies:
- asv == 0.6.1
- numba>=0.58.1 # Pin to specific version for cuda import
- psutil
- pynwb
- dandi
- fsspec
- requests
- aiohttp
- remfile
- pyshark
- lindi
- hdmf @ git+https://github.com/hdmf-dev/hdmf.git@9b3282aa4999d2922f003f1b79ec7458ea3ddc5e # required until PyNWB propagates changes
#- hdmf @ git+https://github.com/hdmf-dev/hdmf.git@expose_aws_region # required until region fix is released
- lindi>=0.3.6
- pynwb @ git+https://github.com/NeurodataWithoutBorders/pynwb.git@expose_aws_region # required until region fix is released
- hdmf @ git+https://github.com/hdmf-dev/hdmf.git@expose_aws_region # required until region fix is released
- hdmf-zarr
- -e ..
Loading