-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fsspec remfile with cache #43
Conversation
Implementation for remfile and fsspec, both with cache
Implemented changes for fsspec and remfile, both with cache
Implemented changes for fsspec and remfile, both with cache
Implemented changes for remfile and fsspec, both with cache
Implemented changes for both fsspec and remfile, both with cache
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like there are a few issues with indentation, but otherwise this looks good to me.
Fixed indentation
Looks good to me minus the syntax issues - @sinha-r can you ensure that you can successfully run the new benchmarks before we merge? |
Fixed indentation
for more information, see https://pre-commit.ci
Indentation fixed
for more information, see https://pre-commit.ci
One more thing I just now realized - apparently doing |
Add dependencies for lindi
Co-authored-by: Cody Baker <[email protected]>
Co-authored-by: Cody Baker <[email protected]>
Co-authored-by: Cody Baker <[email protected]>
Co-authored-by: Cody Baker <[email protected]>
for more information, see https://pre-commit.ci
…ting for TemporaryDirectory
src/nwb_benchmarks/benchmarks/network_tracking_remote_slicing.py
Outdated
Show resolved
Hide resolved
Strange, the main point of |
I've fixed the errors I found and am running the benchmarks now to make sure they work. Otherwise this seems good to merge now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like all the tests ran on my machine at work. Good to merge.
Implementation for fsspec with cache and remfile with cache.
Fix #45