Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boundary for SpatialSeries #567

Merged
merged 16 commits into from
Mar 25, 2024
2 changes: 2 additions & 0 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@

For all schema changes:
- [ ] Add release notes for the PR to `docs/format/source/format_release_notes.rst`.
- [ ] Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.
- [ ] `hdmf-common-schema` needs to point to the latest release and not the latest of the `main ` branch.
rly marked this conversation as resolved.
Show resolved Hide resolved

If this is the first schema change after a schema release (i.e., the version string in `core/nwb.namespace.yaml` does not
end in "-alpha"), then:
Expand Down
18 changes: 18 additions & 0 deletions core/nwb.behavior.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,24 @@ groups:
is 'meters'. Actual stored values are not necessarily stored in these units.
To access the data in these units, multiply 'data' by 'conversion' and add 'offset'.
required: false
- name: bounds
dtype: numeric
doc: The boundary range (min, max) for each dimension of `data`. The units are the same as the units for the data.
shape:
- - 1
- 2
- - 2
- 2
- - 3
- 2
dims:
- - x
- min,max
- - x,y
- min,max
- - x,y,z
- min,max
required: false
- name: reference_frame
dtype: text
doc: Description defining what exactly 'straight-ahead' means.
Expand Down
2 changes: 1 addition & 1 deletion core/nwb.namespace.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -57,4 +57,4 @@ namespaces:
- doc: This source module contains neurodata_type for retinotopy data.
source: nwb.retinotopy.yaml
title: Retinotopy
version: "2.7.0"
version: "2.8.0-alpha"
4 changes: 2 additions & 2 deletions docs/format/source/conf.py
Original file line number Diff line number Diff line change
Expand Up @@ -83,9 +83,9 @@ def setup(app):
# built documents.
#
# The short X.Y version.
version = '2.7.0'
version = '2.8.0-alpha'
# The full version, including alpha/beta/rc tags.
release = '2.7.0'
release = '2.8.0-alpha'

# The language for content autogenerated by Sphinx. Refer to documentation
# for a list of supported languages.
Expand Down
6 changes: 6 additions & 0 deletions docs/format/source/format_release_notes.rst
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,12 @@
Release Notes
=============

2.8.0 (Upcoming)
------------------------
Minor changes
^^^^^^^^^^^^^
- Added support to set boundary metadata for ``SpatialSeries``. (#524)

2.7.0 (February 7, 2024)
------------------------

Expand Down
Loading