-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support .lindi.d directory representation (in addition to .lindi.tar) #92
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #92 +/- ##
===========================================
- Coverage 79.47% 69.09% -10.38%
===========================================
Files 30 33 +3
Lines 2265 3032 +767
===========================================
+ Hits 1800 2095 +295
- Misses 465 937 +472 ☔ View full report in Codecov by Sentry. |
@magland and I discussed and reviewed this PR over video call today. I approve of the general approach. And this PR / the pre-release works with Dendro. We decided to merge this now and make a 0.4.0 release to not block progress on downstream projects. I will do a more thorough review and we can add tests in a later PR. |
This is builds on #89 for supporting a directory representation of a lindi file.
This behaves the same as .lindi.tar except instead of the files and blobs going into the .tar binary file, they go into a directory.
Here's an example
Running this will create a directory with the following files
You can also start from a remote (DANDI) nwb or lindi.nwb file and then augment it using a local directory. This I think is more intuitive compared with the staging area method, and I would propose to replace that.
While I understand that there are advantages of having the blobs be contained in files that are themselves independently open-able, I believe this approach is the way to go when using tools such as pynwb. But this same structure could be used to support other approaches to making a modular NWB... with a tool other than pynwb.
@rly @oruebel