exclude zattrs when empty #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rly
reviewed
Mar 16, 2024
rly
approved these changes
Mar 16, 2024
Co-authored-by: Ryan Ly <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #15
With this, .zattrs is now excluded in the reference file system. However...
I felt it wasn't worth the overhead of determining whether attrs are empty in the
__contains__function, especially since we are adding additional special attributes here and there. So, in the LindiH5Store, the file is still always present. But in the exported reference file system (where this matters more), it is excluded - because that's a much easier check. See notes in source code.This PR also makes some fixes to the
__contains__function and adds some asserts to the tests.