Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect transaction index in MEV Boost processing #183

Merged
merged 3 commits into from
Oct 8, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Node/src/ethereum_l1/execution_layer.rs
Original file line number Diff line number Diff line change
Expand Up @@ -276,7 +276,7 @@ impl ExecutionLayer {
if send_to_contract {
let pending = self.provider_ws.send_raw_transaction(&buf).await?;

tracing::debug!("Proposed new block, with hash {}", pending.tx_hash());
tracing::debug!("Send raw transaction, with hash {}", pending.tx_hash());
mikhailUshakoff marked this conversation as resolved.
Show resolved Hide resolved
}

Ok(buf)
Expand Down
2 changes: 1 addition & 1 deletion Node/src/mev_boost/constraints.rs
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ impl ConstraintsMessage {
.iter()
.map(|message| Constraint {
tx: message.clone(),
index: Some(0),
index: None,
})
.collect();
Self {
Expand Down
2 changes: 2 additions & 0 deletions Node/src/node/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ use operator::{Operator, Status as OperatorStatus};
use preconfirmation_helper::PreconfirmationHelper;
use preconfirmation_message::PreconfirmationMessage;
use preconfirmation_proof::PreconfirmationProof;
use tracing_subscriber::field::debug;
mikhailUshakoff marked this conversation as resolved.
Show resolved Hide resolved
use std::{
collections::HashMap,
sync::{
Expand Down Expand Up @@ -516,6 +517,7 @@ impl Node {
)
.await?;

debug!("Proposed new block, with hash {}", alloy::primitives::keccak256(&tx));
// insert transaction
self.preconfirmation_txs
.lock()
Expand Down
Loading